Kevin Sutter wrote on 8/8/19 7:24 PM:
Hi,
As I continue
to review these PRs, I'm questioning the use of the second
apidocs PR.
How do we plan to process the javadoc that we're pushing to
this
repository?
What do you mean by "process"? For review? Or after approval?
After approval we'll merge the PR and the javadocs will appear on
the jakarta.ee website.
I'm finding it's
easier to review the content of
jakarta.<spec>-<version>-javadoc.jar
file than to review the content on the PR.
The combined
"jakarta
ee api" jar file is created by accessing the maven artifacts and
re-generating
all of the javadoc.
So, I'm just
wondering
what we're accomplishing with the extra PR. Maybe we should
just
have a pointer to the staging repo for the javadoc jar file?
Again,
if we're too late to change the process, then I'm fine with
that. Or,
maybe I need some education as to what the separate PR buys us.
Or,
maybe I'm working too late this evening... :-)
The extra PR avoids cluttering up the main PR and making it
impossible to find the key files that need to be reviewed there.
I'm using the "hub" command as David described to pull the javadoc
PR to my machine and then open it in a browser. I don't try to
review the javadoc PR on GitHub.
|
