Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [jakarta.ee-spec.committee] Guides

Yes, including the java docs exploded does overwhelm the PR. That is why I had suggested including it as a zip, but was not sure how that would be included in a viewable form in the website.

On Jul 11, 2019, at 4:35 PM, Bill Shannon <bill.shannon@xxxxxxxxxx> wrote:

We're still working out some problems with copying the TCK to the download directory.

The EFSL PDF is there.

There is a mail/1.6/mail.md, based on the template Scott included.  Is it supposed to be named index.md?

I find the PR kind of un-reviewable because of the javadocs.  There's just too many files and GitHub can't quite handle it well.


David Blevins wrote on 7/11/19 4:17 PM:
This looks pretty great!

Parts we'd still need are links to the staged EFTL TCK  and staged EFSL PDF.  If projects can give us the link to a staged directory, we can easily make a Jenkins job where all we have to do is feed that in as a parameter and have it both sign and copy the binaries to the final location.  A link to that staged dir somewhere in the template is perfect.

The last part, which likely we can evolve, is we need to create a `mail/1.6/index.adoc` that looks like this:


Almost everything on that page is stuff we could create ourselves, sans the compatible implementations list.  Perhaps that's another PR template implementations have to do and involves a link an approved certification request from the project.

Anyway, that's wonderful.  Feels like this is all coming together.  I like the improvement you have of making that version a dir vs a file (mail/1.6/* vs mail/1.6.md).

-- 
David Blevins




Back to the top