Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
[iot-pmc] [CQ 19587] Eclipse VOLTTRON

http://dev.eclipse.org/ipzilla/show_bug.cgi?id=19587





--- Comment #11 from Jereme Haack <Jereme.Haack@xxxxxxxx>  2019-05-10 13:25:08 ---
(In reply to comment #7)
> (In reply to comment #6)
> > Sorry for the delay on this one, maybe it was a bit too overwhelming. Still you
> > should have gotten a response sooner. You are always welcome to send out an
> > e-mail if you think something takes too long.
> > 
> > I did take a brief look at the archive, and found some stuff that doesn't seem
> > to belong here. Maybe you could clean up that archive a bit, so that we can
> > focus on the relevant stuff.
> > 
> > Like the comment says:
> > 
> > > Please only attach source that is required for the binary distribution.  Items
> > > that do not ship or do not build into binaries are not to be included in the
> > > source attachment.  Typical exclusions are tests, docs, and examples which are
> > > not included in the jar that is shipped.
> > 
> > I guess you are shipping the documentation in one way or the other. And I also
> > believe that for the initial contribution it makes sense to keep the tests.
> 
> My understanding is that the archive MUST contain everything that will go into
> the eclipse repo ...
> 
> > 
> > However I found things like log files, test configs, or code that seems to come
> > form another source:
> > 
> > ---
> > Based on the WhoIsIAm.py sample application from the BACpypes library.
> > ---
> > 
> > Maybe you can re-iterate once more, and clear that out.
> > 
> > I also found a huge amound of 3rd party dependencies. I think it would help if
> > we could have a list of what will be required by the initial CQ from a
> > dependency point of view.
> > 
> 

I added a list I've put together previously about the libraries in our
requirements document.

For the source package, should I take out documentation and tests for IP review
then make a new package for initial commit? Please advise and I can make a more
focused package if needed.


-- 
Configure CQmail: http://dev.eclipse.org/ipzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the CQ.


Back to the top