| Re: [ice-dev] [ice-build] [eclipse/ice] 02e7a1: [Bug 476577] Fixed ICE Import File Wizard |
Robert,
It used to consume it as a service, but I am moving away from services and to Extensions to deal with all of the bundle start stuff. The ReactorAnalyzer in next is broken because of this, but Jordan fixed it in his branch before he left.
Jay
Jay,
I've changed the import file wizard to use the same code from the new item wizard to initialize the Client. It would be best if the ClientHolder consumed the Client as an IClient service, the same way that ReactorClientHolder does. However, my implementation for that caused issues with the bundle loading, and I could not find find a bundle start order that allowed everything to launch properly.
Robert
From: ice-dev-bounces@xxxxxxxxxxx <ice-dev-bounces@xxxxxxxxxxx> on behalf of Jay Jay Billings <jayjaybillings@xxxxxxxxx>
Sent: Thursday, September 10, 2015 12:01 PM
To: ice developer discussions
Subject: Re: [ice-dev] [ice-build] [eclipse/ice] 02e7a1: [Bug 476577] Fixed ICE Import File WizardRobert,
We shouldn't do it that way because it improperly initializes the Client. We need to figure out why the ClientHolder is returning null and fix that.
I think it is because a start method or something on the Client class is not being called, so the reference is never set.
Jay
On Sep 10, 2015 10:53 AM, "GitHub" <noreply@xxxxxxxxxx> wrote:
Branch: refs/heads/next
Home: https://github.com/eclipse/ice
Commit: 02e7a143e74b405e68dec49f78e0217b69bbf0c8
https://github.com/eclipse/ice/commit/02e7a143e74b405e68dec49f78e0217b69bbf0c8
Author: Robert Smith <SmithRW@xxxxxxxx>
Date: 2015-09-10 (Thu, 10 Sep 2015)
Changed paths:
M org.eclipse.ice.client/src/org/eclipse/ice/client/common/wizards/ImportFileWizardPage.java
Log Message:
-----------
[Bug 476577] Fixed ICE Import File Wizard
The ImportFileWizardPage now checks the ClientHolder to see if it has a
Client ready for use and creates one for it if not.
Signed-off-by: Robert Smith <SmithRW@xxxxxxxx>
_______________________________________________
ice-build mailing list
ice-build@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/ice-build
_______________________________________________
ice-dev mailing list
ice-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/ice-dev