Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
[ice-build] [eclipse/ice] 667d2c: [470833]Cleaning up needless code

  Branch: refs/heads/andrew/mars
  Home:   https://github.com/eclipse/ice
  Commit: 667d2cb9d8386caa07619708f9f86d1344ea46c0
      https://github.com/eclipse/ice/commit/667d2cb9d8386caa07619708f9f86d1344ea46c0
  Author: Robert Smith <SmithRW@xxxxxxxx>
  Date:   2015-06-26 (Fri, 26 Jun 2015)

  Changed paths:
    M src/org.eclipse.ice.client/src/org/eclipse/ice/client/common/CoreConnectDialog.java

  Log Message:
  -----------
  [470833]Cleaning up needless code

CoreConnectDialog's createDialogArea method contianed unneccesary code
taking the logical OR of a value with itself. This has been removed.

Bug: 470833 https://bugs.eclipse.org/bugs/show_bug.cgi?id=470833
Signed-off-by: Robert Smith <SmithRW@xxxxxxxx>


  Commit: a0dbd2d66dbea3e0072e3443ff571339b642f7f9
      https://github.com/eclipse/ice/commit/a0dbd2d66dbea3e0072e3443ff571339b642f7f9
  Author: Robert Smith <SmithRW@xxxxxxxx>
  Date:   2015-06-26 (Fri, 26 Jun 2015)

  Changed paths:
    M src/org.eclipse.ice.client.widgets.reactoreditor/src/org/eclipse/ice/client/widgets/reactoreditor/ToolItemMenuListener.java

  Log Message:
  -----------
  [470835]Applied Short Circuit Logic in ToolItemMenuListener

An instance of ToolItemMenuListener using eager logic instead of short
circuit logic in comparision has been changed. The conditional statement
will now only evaulate the secondary statement if the first returned
false.

Bug: 470835 https://bugs.eclipse.org/bugs/show_bug.cgi?id=470835
Signed-off-by: Robert Smith <SmithRW@xxxxxxxx>


  Commit: 17c16776b32ed339e3b4a4db378d6877a074288d
      https://github.com/eclipse/ice/commit/17c16776b32ed339e3b4a4db378d6877a074288d
  Author: Robert Smith <SmithRW@xxxxxxxx>
  Date:   2015-06-26 (Fri, 26 Jun 2015)

  Changed paths:
    M src/org.eclipse.ice.nek5000/src/org/eclipse/ice/nek5000/NekWriter.java

  Log Message:
  -----------
  [470838]Correcting NekWriter to generic linebreaks

NewWriter has been changed to utilize system-agnostic linebreak
characters instead of hardcoded values for. Files created this way have
been confirmed to be formatted correctly under both Linux and Windows.

Bug: 470838 https://bugs.eclipse.org/bugs/show_bug.cgi?id=470838
Signed-off-by: Robert Smith <SmithRW@xxxxxxxx>


  Commit: fe226793eb8075df017379805f37d037704e1b0b
      https://github.com/eclipse/ice/commit/fe226793eb8075df017379805f37d037704e1b0b
  Author: Robert Smith <SmithRW@xxxxxxxx>
  Date:   2015-06-26 (Fri, 26 Jun 2015)

  Changed paths:
    M src/org.eclipse.ice.client.widgets.rcp/src/org/eclipse/ice/client/widgets/mesh/MeshAppState.java

  Log Message:
  -----------
  [470844]MeshAppState floating point equality checking repaired

MeshAppState no longer directly tests for the equality of two floating
point numbers. It instead properly takes the absolute value of their
difference and compares it to a small delta value.

Bug: 470844 https://bugs.eclipse.org/bugs/show_bug.cgi?id=470844
Signed-off-by: Robert Smith <SmithRW@xxxxxxxx>


  Commit: 094646dc6457198effcfa0f4c5907ddfe30a84a7
      https://github.com/eclipse/ice/commit/094646dc6457198effcfa0f4c5907ddfe30a84a7
  Author: Robert Smith <SmithRW@xxxxxxxx>
  Date:   2015-06-26 (Fri, 26 Jun 2015)

  Changed paths:
    M src/org.eclipse.ice.datastructures/src/org/eclipse/ice/datastructures/form/MasterDetailsComponent.java

  Log Message:
  -----------
  470915]Applied Short Circuit Logic MasterDetailsComponent

MasterDetailsComponent now uses short circuit comparisions instead of
eager ones. Thus, it will now only evaulate expressions in an AND until
one evaluates to false, instead of evaluating all of them.

Bug: 470915 https://bugs.eclipse.org/bugs/show_bug.cgi?id=470915
Signed-off-by: Robert Smith <SmithRW@xxxxxxxx>


  Commit: 037744bbeea37ffabcf1eb83cf57b0d75ac26c92
      https://github.com/eclipse/ice/commit/037744bbeea37ffabcf1eb83cf57b0d75ac26c92
  Author: Jay Jay Billings <jayjaybillings@xxxxxxxxx>
  Date:   2015-06-26 (Fri, 26 Jun 2015)

  Changed paths:
    M src/org.eclipse.ice.client/src/org/eclipse/ice/client/common/CoreConnectDialog.java

  Log Message:
  -----------
  Merge pull request #15 from SmithRWORNL/Bug470833

[470833]Cleaning up needless code


  Commit: 4c67c6c00abe98598e65181074caaabe52fbc379
      https://github.com/eclipse/ice/commit/4c67c6c00abe98598e65181074caaabe52fbc379
  Author: Jay Jay Billings <jayjaybillings@xxxxxxxxx>
  Date:   2015-06-26 (Fri, 26 Jun 2015)

  Changed paths:
    M src/org.eclipse.ice.client.widgets.reactoreditor/src/org/eclipse/ice/client/widgets/reactoreditor/ToolItemMenuListener.java

  Log Message:
  -----------
  Merge pull request #16 from SmithRWORNL/Bug470835

[470835]Applied Short Circuit Logic in ToolItemMenuListener


  Commit: 04070d6403bd5ff33220a113fd33800a45b15b0e
      https://github.com/eclipse/ice/commit/04070d6403bd5ff33220a113fd33800a45b15b0e
  Author: Jay Jay Billings <jayjaybillings@xxxxxxxxx>
  Date:   2015-06-26 (Fri, 26 Jun 2015)

  Changed paths:
    M src/org.eclipse.ice.nek5000/src/org/eclipse/ice/nek5000/NekWriter.java

  Log Message:
  -----------
  Merge pull request #17 from SmithRWORNL/Bug470838

[470838]Correcting NekWriter to generic linebreaks


  Commit: 286ac737a54e9fbfc641c6d4087605ad0ed12852
      https://github.com/eclipse/ice/commit/286ac737a54e9fbfc641c6d4087605ad0ed12852
  Author: Jay Jay Billings <jayjaybillings@xxxxxxxxx>
  Date:   2015-06-26 (Fri, 26 Jun 2015)

  Changed paths:
    M src/org.eclipse.ice.datastructures/src/org/eclipse/ice/datastructures/form/MasterDetailsComponent.java

  Log Message:
  -----------
  Merge pull request #19 from SmithRWORNL/Bug470915

470915]Applied Short Circuit Logic MasterDetailsComponent


  Commit: 7392a04aa6f180a9b8e57f0b850d26cb47c8d23c
      https://github.com/eclipse/ice/commit/7392a04aa6f180a9b8e57f0b850d26cb47c8d23c
  Author: Jay Jay Billings <jayjaybillings@xxxxxxxxx>
  Date:   2015-06-26 (Fri, 26 Jun 2015)

  Changed paths:
    M src/org.eclipse.ice.client.widgets.rcp/src/org/eclipse/ice/client/widgets/mesh/MeshAppState.java

  Log Message:
  -----------
  Merge pull request #18 from SmithRWORNL/Bug470844

[470844]MeshAppState floating point equality checking repaired


  Commit: 22091e7e7646e0b2e10bbb7e781b49204dcb5bc9
      https://github.com/eclipse/ice/commit/22091e7e7646e0b2e10bbb7e781b49204dcb5bc9
  Author: Jay Jay Billings <billingsjj@xxxxxxxx>
  Date:   2015-06-26 (Fri, 26 Jun 2015)

  Changed paths:
    M src/org.eclipse.ice.client.widgets.rcp/src/org/eclipse/ice/client/widgets/mesh/MeshAppState.java
    M src/org.eclipse.ice.client.widgets.reactoreditor/src/org/eclipse/ice/client/widgets/reactoreditor/ToolItemMenuListener.java
    M src/org.eclipse.ice.client/src/org/eclipse/ice/client/common/CoreConnectDialog.java
    M src/org.eclipse.ice.datastructures/src/org/eclipse/ice/datastructures/form/MasterDetailsComponent.java
    M src/org.eclipse.ice.nek5000/src/org/eclipse/ice/nek5000/NekWriter.java

  Log Message:
  -----------
  Merge remote-tracking branch 'origin/master' into andrew/mars


Compare: https://github.com/eclipse/ice/compare/165163ab3a19...22091e7e7646

Back to the top