Skip to main content
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [glassfish-dev] Releasing HK2 3.0.5
  • From: "Steve Millidge (Payara)" <steve.millidge@xxxxxxxxxxx>
  • Date: Thu, 5 Oct 2023 13:23:04 +0000
  • Accept-language: en-GB, en-US
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=payara.fish; dmarc=pass action=none header.from=payara.fish; dkim=pass header.d=payara.fish; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=b/X+XVuexyBKmFuSdLUtNPmYtUjhPQqrg+0OFDjhVXk=; b=lItuykH/+cCTfwhVIZyo9DwZKOFtSIAgTJccETSc/S7OY2k3wZoglIBW1oKu7XZCYoQvsteQu3ZUmvOOKkw1ldyxXLwTh25cvJKDV5onUqqafI8ZhNIodp2nSMLiDqUJkRbKi6jalN7EFtdv2QCG0D21asbYmu/WDF2DeWm/Q4gfoTbFbb86FMOjkrzgwURhsvYgmnbZyMC4Dx4SAi68YokB8MaDlV12l5aR/2x0CPeLKQX/as5wFSrDNLakzUkTBo0wzM+xK827tXKMCjrRF3pr8w7QW+t6EBSCaXS1NkOLDcwv0n+2aI3k/QT6zMSL01RgDMPqL4Xp+/NeFPnPAA==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=BitEb6QU6zouuuLjSn/FYUhKlGxrcwAZ22L0a8Nigt7u4xr2RinZTwOASikmnO6t3DMs3KT9YDUnD8A30PPJC7TnYA+CeTZbqobhGaUO7j0tlCJQPhYRlMMsHJLp+ehXGGWIP5BN3tjYINXhAyuHj6WM37KCK4BJHqAD2ITe8zmt3kJ/ZJ9hdJiiIqLtTlamlSjgedFdOtxovDOF3NhvBQjbokgwuHkpPcDhBID4DtI6E65Pa9AnjNxKa8ClN8O3RXlDXt38fFioET3Z9hTkzN4j8yG+s9mhwYJEOf6yb9+mD2QBbVGUSGB1tz38LazBGYEC8N1IRd/JeBMq8UeNog==
  • Delivered-to: glassfish-dev@xxxxxxxxxxx
  • List-archive: <https://www.eclipse.org/mailman/private/glassfish-dev/>
  • List-help: <mailto:glassfish-dev-request@eclipse.org?subject=help>
  • List-subscribe: <https://www.eclipse.org/mailman/listinfo/glassfish-dev>, <mailto:glassfish-dev-request@eclipse.org?subject=subscribe>
  • List-unsubscribe: <https://www.eclipse.org/mailman/options/glassfish-dev>, <mailto:glassfish-dev-request@eclipse.org?subject=unsubscribe>
  • Thread-index: AQHZ9rbN2ZaA7v1dr0eqKNGkAYW3WrA543JAgABVH4CAAI8kCIAASJkCgAAeyMA=
  • Thread-topic: [glassfish-dev] Releasing HK2 3.0.5

I agree if HK2 is still baselined on JDK 11 then it doesn’t need to bump a major version and if that can be used for Jakarta EE 11 great.

 

My comment was more that if you change the required minimum JDK for a version then that deserves a major as it is a breaking change for a class of downstream users.

 

Sounds like that isn’t happening so I am good for HK2 3.0.5.

 

Steve

 

From: glassfish-dev <glassfish-dev-bounces@xxxxxxxxxxx> On Behalf Of David Matejcek via glassfish-dev
Sent: Thursday, October 5, 2023 12:27 PM
To: glassfish-dev@xxxxxxxxxxx
Cc: David Matejcek <david.matejcek@xxxxxxxxxxx>
Subject: Re: [glassfish-dev] Releasing HK2 3.0.5

 

Hi,

 

we need yet 3.0.5 for GlassFish, we are already preparing to start Java21 based developement, but it is still good to "consolidate" everything yet for current JEE10 running on Java17 as  this is currently the preferred version for many users. And sure, we still need to pass all TCK tests with JDK11.

 

The change of the property was suspicious for me too :-)

 

I agree that for JEE11 and JDK21 HK2 should probably move to 4.0.0-SNAPSHOT, but maybe just if we really plan to move significantly forward. If the same build of HK2 can still be compatible with JEE10+11 and GF6+7+8, there is no reason to move the major version. I don't know this yet, maybe you do.

 

David.

 

On 05. 10. 23 12:51, Steve Millidge (Payara) via glassfish-dev wrote:

OK thanks for clarifying. If it is compiled for JDK 11 then +1 from me.

 

I would think a bump of minimum JDK version is more a major. Perhaps start HK2 4.x for Jakarta EE 11 work as that will be compiled JDK 21.

 

 

Steve

 

From: Arjan Tijms <arjan.tijms@xxxxxxxxxxx>
Sent: Thursday, October 5, 2023 11:14 AM
To: Steve Millidge (Payara) <steve.millidge@xxxxxxxxxxx>
Cc: glassfish developer discussions <glassfish-dev@xxxxxxxxxxx>
Subject: Re: [glassfish-dev] Releasing HK2 3.0.5

 

Hi,

 

On Thu, 5 Oct 2023 at 09:08, Steve Millidge (Payara) <steve.millidge@xxxxxxxxxxx> wrote:

Sorry are you saying h2 3.x was previously released compiled jdk17? 

 

Hk2 itself is not compiled for JDK17, but for JDK11:

 

            <plugin>
                <groupId>org.apache.maven.plugins</groupId>
                <artifactId>maven-compiler-plugin</artifactId>
                <configuration>
                    <release>11</release>
                </configuration>
            </plugin>

 

The TCK for GlassFish, which includes all the latest HK2 versions, is run with JDK 11 as well to ensure this. You just need the JDK 17 compiler, hence the requirement. It's a thing that came in with the (optional) Spring module, and its dependencies.

 

That all said, in one of the issues the team did suggest bumping HK2 to 3.1.x, so this may be a good opportunity.

 

Kind regards,

Arjan Tijms



_______________________________________________
glassfish-dev mailing list
glassfish-dev@xxxxxxxxxxx
To unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/glassfish-dev

 

-- 
David Matejcek | OmniFish
david.matejcek@xxxxxxxxxxx

Back to the top