| Re: [glassfish-dev] [jakartaee-tck-dev] GlassFish Passing the TCK |
On 10/15/20 5:13 AM, Steve Millidge (Payara) wrote:
Hi All,Are we in agreement that GlassFish is currently passing the Full and Web Profile TCKs, the CDI TCKs and the other standalone TCKs?Is it consensus view that we should tag a new milestone or RC for GlassFish or shall we wait for the TCK runs on Monday?
+1 for tagging a new something (milestone or RC).Could we still put a hack solution in after tagging for https://github.com/eclipse-ee4j/glassfish/issues/23191 if no one identifies the actual needed code solution?
See possible hack solution mentioned on https://github.com/eclipse-ee4j/glassfish/issues/23191#issuecomment-708977368
Summary  test results CDI TCKhttps://ci.eclipse.org/jakartaee-tck/job/cditck-porting/job/master/106/ <https://ci.eclipse.org/jakartaee-tck/job/cditck-porting/job/master/106/>
It looks like https://ci.eclipse.org/jakartaee-tck/job/bvtck-porting/job/master/98/ passed
It looks like https://ci.eclipse.org/jakartaee-tck/job/ditck-porting/job/master/97/console passed as well.
Combined run of Full Profilehttps://ci.eclipse.org/jakartaee-tck/job/eftl-jakartaeetck-run-900/49/junit-reports-with-handlebars/testSuitesOverview.html <https://ci.eclipse.org/jakartaee-tck/job/eftl-jakartaeetck-run-900/49/junit-reports-with-handlebars/testSuitesOverview.html>https://ci.eclipse.org/jakartaee-tck/job/eftl-jakartaeetck-run-900/48/junit-reports-with-handlebars/testSuitesOverview.html <https://ci.eclipse.org/jakartaee-tck/job/eftl-jakartaeetck-run-900/48/junit-reports-with-handlebars/testSuitesOverview.html>Combined Run of Web Profilehttps://ci.eclipse.org/jakartaee-tck/job/eftl-jakartaeetck-run-web-900/40/ <https://ci.eclipse.org/jakartaee-tck/job/eftl-jakartaeetck-run-web-900/40/> https://ci.eclipse.org/jakartaee-tck/job/eftl-jakartaeetck-run-web-900/42/ <https://ci.eclipse.org/jakartaee-tck/job/eftl-jakartaeetck-run-web-900/42/>and my understanding is that we also don’t have standalone failures suggest that we are passing all tests at the moment.
Yes and https://github.com/eclipse-ee4j/jakartaee-tck/wiki/Jakarta-EE-9-TCK-results agrees with that!
We also ran some Full Platform testing last night that essentially includes the keywords"corba&rmiiop" and the tests marked to be included with those keywords still also pass.
We are still discussing making further changes to the EJB test classes that use org.omg.CORBA.ORB classes. We will ensure that any such changes merged do not introduce failures with GlassFish 6.0 testing.
Does the fact that we are considering making further Platform TCK test changes that will not cause GlassFish 6.0 (or any other implementation) TCK test failures, change whether we tag GlassFish now?
It may be a platform level decision on whether we accept such changes versus waiting until after EE 9 final but we need to complete our due diligence which includes reviewing any further pull requests that are created. Please follow https://www.eclipse.org/lists/jakartaee-tck-dev/msg01042.html mail thread for updates.
Hope this helps, Scott
Steve _______________________________________________ jakartaee-tck-dev mailing list jakartaee-tck-dev@xxxxxxxxxxx To unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/jakartaee-tck-dev