Skip to main content
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [glassfish-dev] Question about steps to release a new version of a glassfish project 
Then OK, if the script is appending it you don't need to pass. Maybe this job is configured like this.

I was under the impression it was configured as described in [1].
[1] https://wiki.eclipse.org/JakartaEE_New_Infra_Release_Job

Thanks
Hussain

-----Original Message-----
From: glassfish-dev-bounces@xxxxxxxxxxx <glassfish-dev-bounces@xxxxxxxxxxx> On Behalf Of sawamura.hiroki@xxxxxxxxxxx
Sent: Thursday, May 21, 2020 12:02 PM
To: glassfish-dev@xxxxxxxxxxx
Subject: Re: [glassfish-dev] Question about steps to release a new version of a glassfish project

Hi Hussain,

Wouldn't the -SNAPSHOT suffix added implicitly?
I'm concerned about the following lines in the Pipeline configuration about adding the -SNAPSHOT suffix to NEXT_VERSION:
```
## Set next SNAPSHOT version and pushed the changes as a new branch ##

echo '-[ Set next snapshot version ]--------------------------------------------------'
find . -name pom.xml -exec \
  sed -i "s|<version>${RELEASE_VERSION}</version>|<version>${NEXT_VERSION}-SNAPSHOT</version>|g" {} \;

echo '-[ Commit modified pom.xml files ]----------------------------------------------'
POM_FILES=`git status | grep -E 'modified:.*pom\.xml' | \
                   sed -e 's/[[:space:]][[:space:]]*modified:[[:space:]][[:space:]]*//'`
git add ${POM_FILES} && \
git commit -m "Prepare next development cycle for ${NEXT_VERSION}"
```

Thanks
Hiroki

-----Original Message-----
From: glassfish-dev-bounces@xxxxxxxxxxx <glassfish-dev-bounces@xxxxxxxxxxx> On Behalf Of Hussain.NM@xxxxxxxxxxxxx
Sent: Thursday, May 21, 2020 3:04 PM
To: glassfish-dev@xxxxxxxxxxx
Subject: Re: [glassfish-dev] Question about steps to release a new version of a glassfish project

Yes your understanding is correct in changing the version in pom.xml to 1.0.11-SNAPSHOT. You can also update the parent version to 1.0.6.

In the release parameters, the NEXT_VERSION should have -SNAPSHOT suffix
- PROJECT : glassfish-security-plugin
 - RELEASE_VERSION : 1.0.11
 - NEXT_VERSION : 1.0.12-SNAPSHOT
 - BRANCH : master
 - DRY_RUN : false
 - OVERWRITE : false

Thanks
Hussain

-----Original Message-----
From: glassfish-dev-bounces@xxxxxxxxxxx <glassfish-dev-bounces@xxxxxxxxxxx> On Behalf Of sawamura.hiroki@xxxxxxxxxxx
Sent: Thursday, May 21, 2020 10:30 AM
To: 'glassfish-dev@xxxxxxxxxxx' <glassfish-dev@xxxxxxxxxxx>
Subject: [glassfish-dev] Question about steps to release a new version of a glassfish project

Hi,

I'm trying to release a new version of glassfish-security-plugin in relation to eclipse-ee4j/glassfish-security-plugin#9[*].
[*] https://apc01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Feclipse-ee4j%2Fglassfish-security-plugin%2Fissues%2F9&amp;data=02%7C01%7Chussain.nm%40cognizant.com%7Cea7ee64b46c54994d6df08d7fd50c360%7Cde08c40719b9427d9fe8edf254300ca7%7C0%7C0%7C637256395637589548&amp;sdata=sEZJown8eY9yEPKzIq2FhL%2FRD8dzmMa6gcWNr9hDnmQ%3D&amp;reserved=0

This is my first time, so let me review the steps to create a release.

First, I researched how other projects are releasing, and I found the following Jenkins job:
https://apc01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fci.eclipse.org%2Fglassfish%2Fview%2Fall%2Fjob%2Fall-projects_1_build-and-stage%2F&amp;data=02%7C01%7Chussain.nm%40cognizant.com%7Cea7ee64b46c54994d6df08d7fd50c360%7Cde08c40719b9427d9fe8edf254300ca7%7C0%7C0%7C637256395637589548&amp;sdata=8%2F99l1l%2F2lB9pN5W2TThG8qfktameEm1j2viEeyWIO4%3D&amp;reserved=0

My understanding is that if I set the appropriate parameters for this job and run it, the release process for the specified project will work automatically.
In this case,
 - PROJECT : glassfish-security-plugin
 - RELEASE_VERSION : 1.0.11
 - NEXT_VERSION : 1.0.12
 - BRANCH : master
 - DRY_RUN : false
 - OVERWRITE : false

I checked the pipeline configuration to be sure, the command of the version rewrite was as follows.
```
SNAPSHOT_VERSION=`mvn ${MVN_EXTRA} -B -C -U -Pstaging  ${HELP_PLUGIN}:evaluate \
                                -Dexpression=project.version 2> /dev/null | \
                egrep '^[0-9]+\.[0-9]+(\.[0-9]+)?-SNAPSHOT$'`
(==snip==)
find . -name pom.xml -exec sed -i "s|<version>${SNAPSHOT_VERSION}</version>|<version>${RELEASE_VERSION}</version>|g" {} \; ```

For glassfish-security-plugin, 1.0.10 is already tagged, but the current project version is 1.0.10-SNAPSHOT.
So, the command that is actually executed is:
```
find . -name pom.xml -exec sed -i "s|<version>1.0.10-SNAPSHOT</version>|<version>1.0.11</version>|g" {} \; ``` Therefore, I'll probably need to manually change the project version to 1.0.11-SNAPSHOT step before jenkins job.

Has my understanding of that been correct so far?

- Hiroki

_______________________________________________
glassfish-dev mailing list
glassfish-dev@xxxxxxxxxxx
To unsubscribe from this list, visit https://apc01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.eclipse.org%2Fmailman%2Flistinfo%2Fglassfish-dev&amp;data=02%7C01%7Chussain.nm%40cognizant.com%7Cea7ee64b46c54994d6df08d7fd50c360%7Cde08c40719b9427d9fe8edf254300ca7%7C0%7C0%7C637256395637589548&amp;sdata=am6p5sOibeJ9iMiY4zktH6z%2FNMnHYxKgE6iMqj5cqkk%3D&amp;reserved=0
This e-mail and any files transmitted with it are for the sole use of the intended recipient(s) and may contain confidential and privileged information. If you are not the intended recipient(s), please reply to the sender and destroy all copies of the original message. Any unauthorized review, use, disclosure, dissemination, forwarding, printing or copying of this email, and/or any action taken in reliance on the contents of this e-mail is strictly prohibited and may be unlawful. Where permitted by applicable law, this e-mail and other e-mail communications sent to and from Cognizant e-mail addresses may be monitored.
This e-mail and any files transmitted with it are for the sole use of the intended recipient(s) and may contain confidential and privileged information. If you are not the intended recipient(s), please reply to the sender and destroy all copies of the original message. Any unauthorized review, use, disclosure, dissemination, forwarding, printing or copying of this email, and/or any action taken in reliance on the contents of this e-mail is strictly prohibited and may be unlawful. Where permitted by applicable law, this e-mail and other e-mail communications sent to and from Cognizant e-mail addresses may be monitored.
_______________________________________________
glassfish-dev mailing list
glassfish-dev@xxxxxxxxxxx
To unsubscribe from this list, visit https://apc01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.eclipse.org%2Fmailman%2Flistinfo%2Fglassfish-dev&amp;data=02%7C01%7Chussain.nm%40cognizant.com%7Cea7ee64b46c54994d6df08d7fd50c360%7Cde08c40719b9427d9fe8edf254300ca7%7C0%7C0%7C637256395637589548&amp;sdata=am6p5sOibeJ9iMiY4zktH6z%2FNMnHYxKgE6iMqj5cqkk%3D&amp;reserved=0
_______________________________________________
glassfish-dev mailing list
glassfish-dev@xxxxxxxxxxx
To unsubscribe from this list, visit https://apc01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.eclipse.org%2Fmailman%2Flistinfo%2Fglassfish-dev&amp;data=02%7C01%7Chussain.nm%40cognizant.com%7Cea7ee64b46c54994d6df08d7fd50c360%7Cde08c40719b9427d9fe8edf254300ca7%7C0%7C0%7C637256395637589548&amp;sdata=am6p5sOibeJ9iMiY4zktH6z%2FNMnHYxKgE6iMqj5cqkk%3D&amp;reserved=0
This e-mail and any files transmitted with it are for the sole use of the intended recipient(s) and may contain confidential and privileged information. If you are not the intended recipient(s), please reply to the sender and destroy all copies of the original message. Any unauthorized review, use, disclosure, dissemination, forwarding, printing or copying of this email, and/or any action taken in reliance on the contents of this e-mail is strictly prohibited and may be unlawful. Where permitted by applicable law, this e-mail and other e-mail communications sent to and from Cognizant e-mail addresses may be monitored.
This e-mail and any files transmitted with it are for the sole use of the intended recipient(s) and may contain confidential and privileged information. If you are not the intended recipient(s), please reply to the sender and destroy all copies of the original message. Any unauthorized review, use, disclosure, dissemination, forwarding, printing or copying of this email, and/or any action taken in reliance on the contents of this e-mail is strictly prohibited and may be unlawful. Where permitted by applicable law, this e-mail and other e-mail communications sent to and from Cognizant e-mail addresses may be monitored.

Back to the top