Re: [glassfish-dev] JDK 11 progress

["sawamura.hiroki@xxxxxxxxxxx" <sawamura.hiroki@xxxxxxxxxxx>]

The return value of Class.getPackage() appears to be different when referencing a class in the default package (It looks like a JDK bug to me, though.). Therefore, a decision using Class.getPackage() may work incorrectly such as "if(Class.getPackage() == null)" on JDK 11.

```
$ cat ./Foo.java 
public class Foo {
    public static void main(String[] args) throws ClassNotFoundException {
        System.out.println( Class.forName("Foo").getPackage() );
    }
}
$ /usr/java/jdk1.8.0_121/bin/javac ./Foo.java 
$ /usr/java/jdk1.8.0_121/bin/java -cp . Foo
null
$ /usr/java/jdk11.0.4_11/bin/java -cp . Foo
package
```

Hiroki

-----Original Message-----
From: glassfish-dev-bounces@xxxxxxxxxxx <glassfish-dev-bounces@xxxxxxxxxxx> On Behalf Of Matej Novotny
Sent: Monday, May 11, 2020 6:41 PM
To: glassfish developer discussions <glassfish-dev@xxxxxxxxxxx>
Subject: Re: [glassfish-dev] JDK 11 progress

Weld 3 and 4 (top of 3.1 and master branch) are at the moment equal in contents apart from the package change in jakarta 9. But I see you weren't running latest Weld 3 anyway so there might be some changes.

WELD-2402 deals with signed classes and generating their proxies into default package. And I think we use Class.getPackage() in several other places too...
What was the JDK 8 -> 11 change around Class.getPackage()?
I am looking at javadocs for both versions and 8 seems to define it in regards to what CL loaded that package whereas 11 as very little documentation.

Sorry if I am bothering, I am just trying to understand what's the issue and if we need to fix something :) There is some JDK 11+ work lining up for Weld anyway (mainly in regards to class defining in SE/servlet) but this sounds like another thing I might bump into.

Matej

----- Original Message -----
> From: "sawamura hiroki" <sawamura.hiroki@xxxxxxxxxxx>
> To: "glassfish developer discussions" <glassfish-dev@xxxxxxxxxxx>
> Sent: Friday, May 8, 2020 2:47:27 AM
> Subject: Re: [glassfish-dev] JDK 11 progress
> 
> Hi Matej
> 
> Due to changes in the Class.getPackage() work between JDK 8 and JDK 
> 11, the following classes in weld-core 3.0.0 were not working well on 
> JDK11. I haven't been able to confirm the work of weld4 yet, but I 
> thought it was necessary to incorporate the latest weld in order to give feedback.
> -
> https://github.com/weld/core/blob/3.0.0.Final/impl/src/main/java/org/j
> boss/weld/bean/proxy/ProxyFactory.java
> | The issue and commit below may have fixed it.
> |  - https://issues.redhat.com/browse/WELD-2402
> |  -
> |  
> | https://github.com/weld/core/commit/b9c476e317087a626e27d6934aae85ea
> | f78ef60d#diff-fdee1befd5c4423400c0ac3d542b3f72
> | However, due to the effect of the following commit, it could not be 
> | simply incorporated.
> |  -
> |  
> | https://github.com/weld/api/commit/8b730af1056cec20327d87af0ff291af8
> | 62de684
> 
> > Furthermore, this PR 
> > https://github.com/eclipse-ee4j/glassfish/pull/22969
> > seems to incorporate Weld 4 into the mix already.
> I overlooked it. Thanks!
> 
> Hiroki
> 
> -----Original Message-----
> From: glassfish-dev-bounces@xxxxxxxxxxx 
> <glassfish-dev-bounces@xxxxxxxxxxx>
> On Behalf Of Matej Novotny
> Sent: Thursday, May 7, 2020 11:25 PM
> To: glassfish developer discussions <glassfish-dev@xxxxxxxxxxx>
> Subject: Re: [glassfish-dev] JDK 11 progress
> 
> Hi
> 
> What is the link between Weld 4 and JDK 11 compliance? GF was running 
> Weld 3 already which should be compliant (we are running Weld 3 under 
> JDK 11 with tests and all).
> The only difference between top of 3.1 branch and 4.x branch is the 
> namespace change.
> 
> Furthermore, this PR 
> https://github.com/eclipse-ee4j/glassfish/pull/22969
> seems to incorporate Weld 4 into the mix already.
> Either way, if you hit problems with Weld integration, keep me in the loop.
> 
> Regards,
> Matej
> 
> ----- Original Message -----
> > From: "sawamura hiroki" <sawamura.hiroki@xxxxxxxxxxx>
> > To: "glassfish developer discussions" <glassfish-dev@xxxxxxxxxxx>
> > Sent: Thursday, May 7, 2020 11:59:49 AM
> > Subject: Re: [glassfish-dev] JDK 11 progress
> > 
> > Hi Steve,
> > 
> > I created a draft PR:
> > https://github.com/eclipse-ee4j/glassfish/pull/22979
> > 
> > In order for GlassFish to be JDK 11 compliant, we need to integrate 
> > the latest weld-core* (compatible with weld-api 4.0 and later) into 
> > GlassFish, but it is not simple and has been put on hold. If anyone 
> > has times, I'd be happy if they would try.
> > It can be developed on the master branch independently of JDK 11.
> > 
> > *) https://github.com/weld/core
> >    (to glassfish: /appserver/web/weld-integration)
> > 
> > Thanks,
> > Hiroki
> > 
> > From: glassfish-dev-bounces@xxxxxxxxxxx 
> > <glassfish-dev-bounces@xxxxxxxxxxx>
> > On Behalf Of Steve Millidge (Payara)
> > Sent: Thursday, May 7, 2020 5:46 PM
> > To: glassfish developer discussions <glassfish-dev@xxxxxxxxxxx>
> > Subject: [glassfish-dev] JDK 11 progress
> > 
> > Hi All,
> > 
> > Is there any progress on the work to get GlassFish compiling and 
> > running against JDK 11? If assistance is needed can the latest work 
> > be pushed to a branch or in a draft PR that way others can help.
> > 
> > 
> > 
> > Steve Millidge
> > Director and Founder
> > Payara Server – Open Source Enterprise Software and Support
> > E: mailto:steve.millidge@xxxxxxxxxxx | T: +44 207 7540481  |M: +44
> > 07920
> > 100626
> > --------------------------------------------------------------------
> > --
> > ------------------------------------------------
> > Payara Services Limited, Registered office: Malvern Hills Science 
> > Park, Geraldine Road, Malvern, WR14 3SZ Registered in England and
> > Wales: 09998946 | http://www.payara.fish/ | mailto:info@xxxxxxxxxxx 
> > | https://twitter.com/Payara_Fish If at any time you would like to 
> > unsubscribe from Payara communications, simply respond to this email 
> > with 'Unsubscribe' in the title, or instantly unsubscribe from all 
> > types of communication 
> > https://info.payara.fish/hs/manage-preferences/unsubscribe-simple
> > 
> > _______________________________________________
> > glassfish-dev mailing list
> > glassfish-dev@xxxxxxxxxxx
> > To unsubscribe from this list, visit 
> > https://www.eclipse.org/mailman/listinfo/glassfish-dev
> > 
> 
> _______________________________________________
> glassfish-dev mailing list
> glassfish-dev@xxxxxxxxxxx
> To unsubscribe from this list, visit
> https://www.eclipse.org/mailman/listinfo/glassfish-dev
> _______________________________________________
> glassfish-dev mailing list
> glassfish-dev@xxxxxxxxxxx
> To unsubscribe from this list, visit
> https://www.eclipse.org/mailman/listinfo/glassfish-dev
> 

_______________________________________________
glassfish-dev mailing list
glassfish-dev@xxxxxxxxxxx
To unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/glassfish-dev