Same thing is discussed in this JSON-P PR integration
https://github.com/eclipse-ee4j/glassfish/pull/22943 where JSON-P should have a small impact given it is a new api but it needs an updated Jersey or the server won’t start.
Steve
From: glassfish-dev-bounces@xxxxxxxxxxx <glassfish-dev-bounces@xxxxxxxxxxx>
On Behalf Of Steve Millidge (Payara)
Sent: 23 March 2020 15:40
To: glassfish developer discussions <glassfish-dev@xxxxxxxxxxx>
Subject: Re: [glassfish-dev] Splitting up the jakarta work
Problem is the code doesn’t compile unless we potentially go through an implementation phase when we support two versions of the library e.g. Jakarta Transactions at the same time with both javax
and Jakarta as dependencies which means adding the new dependency in some places then unpicking it later. Which seems brittle.
For example I tried to add Jakarta Transactions as it is needed for Jakarta Connectors. So I started changing namespace of references to it in the code base. Unfortunately it is used in public javax
EJB apis so now the GlassFish EJB code does not implement javax.ejb interfaces so I need to update EJB to use Jakarta namespace and so on and so on…
I’m tempted to change all namespace in one go and fix compilation errors but then I suspect I will also need all the upstream implementation projects to be ready that are not part of GlassFish or
I suspect the server won’t start with OSGI errors. Yuk.
Steve
Can this not be one, one library at a time? That is, each PR handles the changes for the library and all of its references, but no more?
Russ
I recently started trying to do the work to integrate Jakarta connectors namespace change as the implementation of the api is in core GlassFish. However to do so I also had to start doing the work on Jakarta transactions. Also now I’ve
hit that I also need to do all the changes for EJB as well or GlassFish won’t compile. I have a horrible suspicion that this change is likely going to suck in a lot of the apis and hit a huge chunk of the code base.
Does anybody have any good ideas on how to work in parallel on a lot of this work?
I’m starting to think that a large chunk of the work is going to have to be done in one go in one PR!
Does anybody have a better idea?
_______________________________________________
glassfish-dev mailing list
glassfish-dev@xxxxxxxxxxx
To unsubscribe from this list, visit https://urldefense.com/v3/__https://www.eclipse.org/mailman/listinfo/glassfish-dev__;!!GqivPVa7Brio!KCrJfd9RxFJu3Yvq84Jj8UgY83QDwEKWPYX5Hw-_GeC1B3j0wOFQUWQ7x_RKjmE-7w$
