| 
Hi Thomas,   Feel free to issue the PR so we review/merge this!   Thanks!   Kind regards, Manfred Riem   
From: faces-dev <faces-dev-bounces@xxxxxxxxxxx> On Behalf Of
Thomas AndraschkoSent: Tuesday, February 16, 2021 2:50 AM
 To: mojarra developer discussions <mojarra-dev@xxxxxxxxxxx>; faces developer discussions <faces-dev@xxxxxxxxxxx>
 Subject: Re: [faces-dev] Faces 4.0: ClientWindowScoped prototyped in MyFaces
   
it would also be ok if you agree with the API change (the new @ClientWindowScoped), everything else is impl detail. in MyFaces we just store a Map<ClientWindowId, BeanStorage> in the ExternalContext.   
any feedback here? would really like to get a bit more drive into 4.0 spec.   
In general this is a simple scope based on our ClientWindow, which can be accessed via ExternalContext. DeltaSpike has it since ages. This implementation is a simple Map inside the session, which has a "contextual storage" for beans, for each windowId. The only thing missing is maybe a max-limit for the clientWindowId<>Storage map. In DeltaSpike its configurable with a default of 1024. I think we could maybe limit it to 128 or 256, or introduce a context param. But i don't think the configparam is much used in the DS community. WDYT? 
If you are ok with it, i could also try to provide a mojarra PR here. Best regards, Thomas |