Re: [emfcloud-dev] Actions before merging a Pull Request and implicit co

[Tobias Ortmayr <tortmayr@xxxxxxxxxxxxxxxxx>]

Hi Vincent,

Thank you for raising these questions. We should definitely add this information to the CONTRIBUTING.md files and maybe we could also establish some general review 

guidelines in the future.

As a committer, can I directly merge the PR that seems relevant to me, or should I make sure with the rest of the team that it can be inserted in the sprint's scope ?

 

For your own PRs a positive peer review of another committer is required before merging. If you are reviewing external PRs it depends on the size of the change. 

For simple bug fixes, documentation updates etc. just go ahead and merge them after you have given your approval. For larger or conflicting changes (or if you are unsure) 

please tag one of the project leads (@eneufeld, @planger, @koegel ).

How can I check that the Eclipse Source team is not in the middle of a release process nor in a code freeze ?

 

In case of a pending release or other code freeze there should be a general announcement on the default communication channels (discussions + dev mailing list).

Is there any manual action I should take regarding https://github.com/orgs/eclipse-emfcloud/projects/2 ? Or is only the project leader in charge of it ?

 

Managing the project board is mostly the responsibility of the project leads. However, there are a couple of actions you can take to ease the process for them:

• If possible, always create an accompanying issue for your PR. Issues are easier to track and manage in the project board
• When you create new issues please directly add them to the `EMFCloud` project. Please self-assign if you plan to work on the issue.
• If your PR resolves the corresponding issue please add a `Fixes` notice to the commit message/PR description. (e.g. `Fixes #123` or `Closes #123)

From what I have seen, the practice on the project seem to be to have at least one positive peer-review on the PR, even for committers. Can you confirm that ?

Exactly, each PR should have at least one positive peer-review before it's merged.

Best regards,
Tobias

On Wed, Jul 6, 2022 at 4:06 PM HEMERY Vincent <vincent.hemery@xxxxxxxxxx> wrote:

Hello,

I was reviewing PR https://github.com/eclipse-emfcloud/emfjson-jackson/pull/39

Before merging any PR, I wanted to make sure it wasn't too hasty. So I have a few questions :

• As a committer, can I directly merge the PR that seems relevant to me, or should I make sure with the rest of the team that it can be inserted in the sprint's scope ? How can I check that the Eclipse Source team is not in the middle of a release process nor in a code freeze ?
  
• Is there any manual action I should take regarding https://github.com/orgs/eclipse-emfcloud/projects/2 ? Or is only the project leader in charge of it ?
  
• From what I have seen, the practice on the project seem to be to have at least one positive peer-review on the PR, even for committers. Can you confirm that ?

Thank you in advance for the clarifications.

Eventually these answers can be reported to the CONTRIBUTING.md files, like https://github.com/eclipse-emfcloud/emfjson-jackson/blob/master/CONTRIBUTING.md

--

Best regards,

	Vincent HEMERY Eclipse and Modeling Expert BUSINESS UNIT ESPACE   +33 561 176 310 / +33 683 931 631   vincent.hemery@xxxxxxxxxx

_______________________________________________
emfcloud-dev mailing list
emfcloud-dev@xxxxxxxxxxx
To unsubscribe from this list, visit https://dev.eclipse.org/mailman/listinfo/emfcloud-dev

--

Tobias Ortmayr

Senior Software Engineer

EclipseSource Austria

Email: tortmayr@xxxxxxxxxxxxxxxxx

Web: https://eclipsesource.com/austria

EclipseSource Services GmbH

Schwindgasse 20 / 2-3

1040 Wien

General Manager: Dr. Philip Langer

Registered Office: Schwindgasse 20 / 2-3, 1040 Wien; Handelsgericht Wien, FN 421413a