| Re: [elk-dev] ELK Refactoring |
Hey there! I finished going through the pull request. Since your pull request was too large to be displayed by GitHub, I added my comments in the code and pushed them to a new branch: http://tinyurl.com/hn8mayk All in all, things seem a lot easier now. Did you remove the SelectionInfoAction because people are supposed to configure layout through LayoutConfigurators now anyway where they have direct access to all classes? On 08/01/16 09:46, Miro Spönemann wrote: > Could you share the projects of the mindmap editor? Maybe not in the > repository, a zip download would be enough for me. Sure, here you go: http://informatik.uni-kiel.de/~cds/mindmap.zip >> How much is there to be customized, really? I guess I would like to see >> a concrete set of proposals to think about. > > Potential places for customization: > — IDiagramLayoutManager > — ILayoutConfigurationStore > — LayoutConfigurationManager > — IGraphLayoutEngine > — Some parts of DiagramLayoutEngine > — LayoutPropertySource > > My idea: instead of registering an IDiagramLayoutManager directly > through the extension point, you register some Setup class that is able > to create a Guice Injector. That one is cached in > the LayoutManagersService and used to create instances of the classes > mentioned above. I'm not sure I see the benefit there, but then again I so far haven't messed with injection much. That may be something to talk about in person sometime. Cheers, Christoph Daniel
Attachment:
signature.asc
Description: OpenPGP digital signature