| Re: [elk-dev] Some code migration details |
Hi there! On 21/09/15 08:28, Miro Spönemann wrote: > Moin, > >> On 20.09.2015, at 12:43, Christoph Daniel Schulze <cds@xxxxxxxxxxxxxxxxxxxxxx> wrote: >> kgraph.text and kgraph.text.ui >> We wanted these to be part of ELK (which I still think would be useful). >> However, they both depend on core.krendering. Did we foresee this >> problem and decide what to do about it already? Miro, you thought about >> rewriting the grammar entirely. How about leaving the original >> kgraph.text and kgraph.text.ui plug-ins out of ELK? This would also >> allow us to keep them around in KIELER for a while for migration purposes. > > Yes, let’s leave the current kgraph.text as it is so .*kgt files including rendering can still be processed. I would create a new text plugin from scratch for the ElkGraph. We should choose new file extensions anyway, since we decided to leave the old KGraph alive for easier migration of graphs. What about *.egx and *.egt? .egx and .egt sound good. Can we extend the language in the KIELER project to support KRendering? >> kgraph.text.ui, graphviz.dot, and graphviz.layouter >> These all depend on kiml.formats which we decided to keep in KIELER. We >> could include the base formats plugin in ELK, but leave the formats.* >> plugins in KIELER. What do you think? > > I would rather eliminate the dependency. The actual layout algorithm does not require it. The file format support could be extracted to a new plugin ok KIELER. Agreed and done. We now have a new plug-in, kiml.formats.dot, that integrates dot support into KIELER. For time reasons, I pretty much duplicated the TransformationData class instead of integrating it into DotImporter and DotExporter. If someone has time on his hands, that would be something one could take a look at. But then again, it works just fine as it is... ;) I'll continue putting the initial commit together tomorrow. Cheers, Christoph Daniel
Attachment:
signature.asc
Description: OpenPGP digital signature