Re: [eclipse.org-architecture-council] Automating quality gates on contr

[Wayne Beaton <wayne.beaton@xxxxxxxxxxxxxxxxxxxxxx>]

I tend to agree with Gunnar. Tools exist for this already and we're probably better served using them rather than inventing new ones.

FWIW, we've been working with ClearyDefined for a while. Sharon has been participating in their curation meetings, and I've been experimenting with using their data for IP review (more here, more coming soon). ClearlyDefined data is how we're going to get rid of most of our third party CQs.

One of the things that I haven't put much thought into yet is how we get more information about our content into ClearlyDefined (e.g., last time I checked, there was no notion of content that comes from p2 repositories).  

Wayne

On Sun, Feb 2, 2020 at 1:36 PM Gunnar Wagenknecht <gunnar@xxxxxxxxxxxxxxx> wrote:

While I do see value in this proposal I'm not confident that the ECA check tool is the right candidate for this (implementing too many concerns in that app).

Wouldn't it be better to use existing tools/plug-ins, which already do these kind of checks and publish pom.xml blueprints for Maven/Tycho based projects? Seems like an easier way to implement.

-Gunnar

-- 
Gunnar Wagenknecht
gunnar@xxxxxxxxxxxxxxx, http://guw.io/

On Feb 2, 2020, at 18:39, Mickael Istria <mistria@xxxxxxxxxx> wrote:

Hi all,

I had the opportunity to attend FOSDEM and see a talk about dependency management by Jeff McCaffer, mentioning among others ClearlyDefined.

Then the discussion went more into the best practices to get high quality Open-Source software and community. Not so surprisingly, one key point is automation of quality checks during reviews, and the licensing of files was mentioned as a quality criterion.

So I think to improve a bit our practices with an easily executable change, the ECA check that runs on Gerrit review and GitHub PRs should also check the added text file have a copyright header, and report an helpful error otherwise: https://bugs.eclipse.org/bugs/show_bug.cgi?id=559768

Cheers

--

Mickael Istria

Eclipse IDE developer, for Red Hat Developers

_______________________________________________
eclipse.org-architecture-council mailing list
eclipse.org-architecture-council@xxxxxxxxxxx
https://www.eclipse.org/mailman/listinfo/eclipse.org-architecture-council

IMPORTANT: Membership in this list is generated by processes internal to the Eclipse Foundation.  To be permanently removed from this list, you must contact emo@xxxxxxxxxxx to request removal.

_______________________________________________
eclipse.org-architecture-council mailing list
eclipse.org-architecture-council@xxxxxxxxxxx
https://www.eclipse.org/mailman/listinfo/eclipse.org-architecture-council

IMPORTANT: Membership in this list is generated by processes internal to the Eclipse Foundation.  To be permanently removed from this list, you must contact emo@xxxxxxxxxxx to request removal.

--

Wayne Beaton

Director of Open Source Projects | Eclipse Foundation, Inc.