Re: [eclipse-dev] line split of 800 characters in project settings

[Jonah Graham <jonah@xxxxxxxxxxxxxxxx>]

>  Do you want to provide a patch?

I will provide a patch - (although if an Equinox committer prefers, let me know).

> I recommend switching the projects to use the Eclipse Formatter. IMHO it is good to use our default settings. This one was updated to use 120 line length.

Lars, do you mean have no formatter settings stored in the projects and let the projects use workspace defaults? Or to reapply all the current defaults in Eclipse ot the individual projects, if the latter I can do that too.

BTW CDT uses a script to verify that all projects follow the CDT standards and this is checked at gerrit verification time. For example project settings are checked with [1] - there are a bunch of such checks that verify code is formatted properly, files have no trailing whitespace, etc. See [2] for a full list of cleanups that are automatically checked.

[1] https://git.eclipse.org/r/plugins/gitiles/cdt/org.eclipse.cdt/+/refs/heads/master/releng/scripts/do_project_settings.sh

[2] https://git.eclipse.org/r/plugins/gitiles/cdt/org.eclipse.cdt/+/refs/heads/master/releng/scripts/do_all_code_cleanups.sh

Jonah

~~~
Jonah Graham
Kichwa Coders
www.kichwacoders.com

On Mon, 18 Oct 2021 at 10:10, Andrey Loskutov <loskutov@xxxxxx> wrote:

I assume that this was a copy/paste or search/replace issue. 80 was meant for sure.

I would vote for changing 800 to 120, please be careful not to change it to 1200 :-)

Do you want to provide a patch?
 

Kind regards,
Andrey Loskutov

Спасение утопающих - дело рук самих утопающих

https://www.eclipse.org/user/aloskutov

 

 

Gesendet: Montag, 18. Oktober 2021 um 16:02 Uhr
Von: "Jonah Graham" <jonah@xxxxxxxxxxxxxxxx>
An: "General development mailing list of the Eclipse project." <eclipse-dev@xxxxxxxxxxx>
Betreff: [eclipse-dev] line split of 800 characters in project settings

Hi folks,

 

A whole bunch of the equinox projects[1] have JDT formatter set to split lines at 800 characters. While eclipse.platform.runtime[2] (the only other git repo I checked) consistently uses 120.

 

I have been doing some editing and reviewing of changes related to Adapters and I have been finding the excessively long lines rather offputting (e.g. even with gerrit set to 150 chars wide I still see wrapping - and putting it to 150 wide also puts the left and right hand sides further apart).

 

Is this very long line length intentional / out of date? Are such long lines a valid reason to -1 a patch.

 

Thanks

Jonah

 

 

[1] $ git grep org.eclipse.jdt.core.formatter.lineSplit=
bundles/org.eclipse.equinox.app/.settings/org.eclipse.jdt.core.prefs:org.eclipse.jdt.core.formatter.lineSplit=800
bundles/org.eclipse.equinox.bidi.tests/.settings/org.eclipse.jdt.core.prefs:org.eclipse.jdt.core.formatter.lineSplit=800
bundles/org.eclipse.equinox.bidi/.settings/org.eclipse.jdt.core.prefs:org.eclipse.jdt.core.formatter.lineSplit=800
bundles/org.eclipse.equinox.cm.test/.settings/org.eclipse.jdt.core.prefs:org.eclipse.jdt.core.formatter.lineSplit=800
bundles/org.eclipse.equinox.cm/.settings/org.eclipse.jdt.core.prefs:org.eclipse.jdt.core.formatter.lineSplit=800
bundles/org.eclipse.equinox.common.tests/.settings/org.eclipse.jdt.core.prefs:org.eclipse.jdt.core.formatter.lineSplit=120
bundles/org.eclipse.equinox.common/.settings/org.eclipse.jdt.core.prefs:org.eclipse.jdt.core.formatter.lineSplit=800
bundles/org.eclipse.equinox.compendium.tests/.settings/org.eclipse.jdt.core.prefs:org.eclipse.jdt.core.formatter.lineSplit=800
bundles/org.eclipse.equinox.coordinator/.settings/org.eclipse.jdt.core.prefs:org.eclipse.jdt.core.formatter.lineSplit=800
bundles/org.eclipse.equinox.device/.settings/org.eclipse.jdt.core.prefs:org.eclipse.jdt.core.formatter.lineSplit=800
bundles/org.eclipse.equinox.event/.settings/org.eclipse.jdt.core.prefs:org.eclipse.jdt.core.formatter.lineSplit=800
bundles/org.eclipse.equinox.http.jetty.starter/.settings/org.eclipse.jdt.core.prefs:org.eclipse.jdt.core.formatter.lineSplit=800
bundles/org.eclipse.equinox.http.jetty/.settings/org.eclipse.jdt.core.prefs:org.eclipse.jdt.core.formatter.lineSplit=800
bundles/org.eclipse.equinox.http.registry/.settings/org.eclipse.jdt.core.prefs:org.eclipse.jdt.core.formatter.lineSplit=800
bundles/org.eclipse.equinox.http.servlet/.settings/org.eclipse.jdt.core.prefs:org.eclipse.jdt.core.formatter.lineSplit=80
bundles/org.eclipse.equinox.http.servletbridge/.settings/org.eclipse.jdt.core.prefs:org.eclipse.jdt.core.formatter.lineSplit=800
bundles/org.eclipse.equinox.io/.settings/org.eclipse.jdt.core.prefs:org.eclipse.jdt.core.formatter.lineSplit=800
bundles/org.eclipse.equinox.ip/.settings/org.eclipse.jdt.core.prefs:org.eclipse.jdt.core.formatter.lineSplit=800
bundles/org.eclipse.equinox.jsp.jasper.registry/.settings/org.eclipse.jdt.core.prefs:org.eclipse.jdt.core.formatter.lineSplit=800
bundles/org.eclipse.equinox.jsp.jasper/.settings/org.eclipse.jdt.core.prefs:org.eclipse.jdt.core.formatter.lineSplit=800
bundles/org.eclipse.equinox.log.stream/.settings/org.eclipse.jdt.core.prefs:org.eclipse.jdt.core.formatter.lineSplit=800
bundles/org.eclipse.equinox.metatype/.settings/org.eclipse.jdt.core.prefs:org.eclipse.jdt.core.formatter.lineSplit=800
bundles/org.eclipse.equinox.preferences/.settings/org.eclipse.jdt.core.prefs:org.eclipse.jdt.core.formatter.lineSplit=800
bundles/org.eclipse.equinox.region.tests/.settings/org.eclipse.jdt.core.prefs:org.eclipse.jdt.core.formatter.lineSplit=120
bundles/org.eclipse.equinox.region/.settings/org.eclipse.jdt.core.prefs:org.eclipse.jdt.core.formatter.lineSplit=800
bundles/org.eclipse.equinox.registry/.settings/org.eclipse.jdt.core.prefs:org.eclipse.jdt.core.formatter.lineSplit=800
bundles/org.eclipse.equinox.security.macosx/.settings/org.eclipse.jdt.core.prefs:org.eclipse.jdt.core.formatter.lineSplit=800
bundles/org.eclipse.equinox.security.tests/.settings/org.eclipse.jdt.core.prefs:org.eclipse.jdt.core.formatter.lineSplit=120
bundles/org.eclipse.equinox.security.ui/.settings/org.eclipse.jdt.core.prefs:org.eclipse.jdt.core.formatter.lineSplit=800
bundles/org.eclipse.equinox.security/.settings/org.eclipse.jdt.core.prefs:org.eclipse.jdt.core.formatter.lineSplit=800
bundles/org.eclipse.equinox.servletbridge/.settings/org.eclipse.jdt.core.prefs:org.eclipse.jdt.core.formatter.lineSplit=800
bundles/org.eclipse.equinox.transforms.hook/.settings/org.eclipse.jdt.core.prefs:org.eclipse.jdt.core.formatter.lineSplit=800
bundles/org.eclipse.equinox.transforms.xslt/.settings/org.eclipse.jdt.core.prefs:org.eclipse.jdt.core.formatter.lineSplit=800
bundles/org.eclipse.equinox.useradmin/.settings/org.eclipse.jdt.core.prefs:org.eclipse.jdt.core.formatter.lineSplit=800
bundles/org.eclipse.equinox.util/.settings/org.eclipse.jdt.core.prefs:org.eclipse.jdt.core.formatter.lineSplit=800
bundles/org.eclipse.equinox.weaving.caching.j9/.settings/org.eclipse.jdt.core.prefs:org.eclipse.jdt.core.formatter.lineSplit=80
bundles/org.eclipse.equinox.weaving.caching/.settings/org.eclipse.jdt.core.prefs:org.eclipse.jdt.core.formatter.lineSplit=80
bundles/org.eclipse.equinox.weaving.hook/.settings/org.eclipse.jdt.core.prefs:org.eclipse.jdt.core.formatter.lineSplit=80
bundles/org.eclipse.equinox.wireadmin/.settings/org.eclipse.jdt.core.prefs:org.eclipse.jdt.core.formatter.lineSplit=800

 

 

[2] 

$ git grep org.eclipse.jdt.core.formatter.lineSplit=
bundles/org.eclipse.core.contenttype/.settings/org.eclipse.jdt.core.prefs:org.eclipse.jdt.core.formatter.lineSplit=120
bundles/org.eclipse.core.expressions/.settings/org.eclipse.jdt.core.prefs:org.eclipse.jdt.core.formatter.lineSplit=120
bundles/org.eclipse.core.jobs/.settings/org.eclipse.jdt.core.prefs:org.eclipse.jdt.core.formatter.lineSplit=120
bundles/org.eclipse.core.runtime/.settings/org.eclipse.jdt.core.prefs:org.eclipse.jdt.core.formatter.lineSplit=120
bundles/org.eclipse.core.tools/.settings/org.eclipse.jdt.core.prefs:org.eclipse.jdt.core.formatter.lineSplit=120
bundles/org.eclipse.e4.core.contexts/.settings/org.eclipse.jdt.core.prefs:org.eclipse.jdt.core.formatter.lineSplit=120
bundles/org.eclipse.e4.core.di.annotations/.settings/org.eclipse.jdt.core.prefs:org.eclipse.jdt.core.formatter.lineSplit=120
bundles/org.eclipse.e4.core.di.extensions.supplier/.settings/org.eclipse.jdt.core.prefs:org.eclipse.jdt.core.formatter.lineSplit=120
bundles/org.eclipse.e4.core.di.extensions/.settings/org.eclipse.jdt.core.prefs:org.eclipse.jdt.core.formatter.lineSplit=120
bundles/org.eclipse.e4.core.di/.settings/org.eclipse.jdt.core.prefs:org.eclipse.jdt.core.formatter.lineSplit=120
bundles/org.eclipse.e4.core.services/.settings/org.eclipse.jdt.core.prefs:org.eclipse.jdt.core.formatter.lineSplit=120
tests/org.eclipse.core.contenttype.tests/.settings/org.eclipse.jdt.core.prefs:org.eclipse.jdt.core.formatter.lineSplit=120
tests/org.eclipse.core.expressions.tests/.settings/org.eclipse.jdt.core.prefs:org.eclipse.jdt.core.formatter.lineSplit=120
tests/org.eclipse.core.tests.harness/.settings/org.eclipse.jdt.core.prefs:org.eclipse.jdt.core.formatter.lineSplit=120
tests/org.eclipse.core.tests.runtime/.settings/org.eclipse.jdt.core.prefs:org.eclipse.jdt.core.formatter.lineSplit=120
tests/org.eclipse.e4.core.tests/.settings/org.eclipse.jdt.core.prefs:org.eclipse.jdt.core.formatter.lineSplit=120

~~~
Jonah Graham
Kichwa Coders
www.kichwacoders.com

_______________________________________________ eclipse-dev mailing list eclipse-dev@xxxxxxxxxxx To unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/eclipse-dev

_______________________________________________
eclipse-dev mailing list
eclipse-dev@xxxxxxxxxxx
To unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/eclipse-dev