Re: [eclipse-dev] line split of 800 characters in project settings

[Lars Vogel <lars.vogel@xxxxxxxxxxx>]

Hi Jonah,

I recommend switching the projects to use the Eclipse Formatter. IMHO it is good to use our default settings. This one was updated to use 120 line length.

Please open a bug and push a Gerrit for this if no-one else thinks 800 is a useful setting..

Best regards, Lars

Jonah Graham <jonah@xxxxxxxxxxxxxxxx> schrieb am Mo., 18. Okt. 2021, 16:02:

Hi folks,

A whole bunch of the equinox projects[1] have JDT formatter set to split lines at 800 characters. While eclipse.platform.runtime[2] (the only other git repo I checked) consistently uses 120.

I have been doing some editing and reviewing of changes related to Adapters and I have been finding the excessively long lines rather offputting (e.g. even with gerrit set to 150 chars wide I still see wrapping - and putting it to 150 wide also puts the left and right hand sides further apart).

Is this very long line length intentional / out of date? Are such long lines a valid reason to -1 a patch.

Thanks

Jonah

[1] $ git grep org.eclipse.jdt.core.formatter.lineSplit=
bundles/org.eclipse.equinox.app/.settings/org.eclipse.jdt.core.prefs:org.eclipse.jdt.core.formatter.lineSplit=800
bundles/org.eclipse.equinox.bidi.tests/.settings/org.eclipse.jdt.core.prefs:org.eclipse.jdt.core.formatter.lineSplit=800
bundles/org.eclipse.equinox.bidi/.settings/org.eclipse.jdt.core.prefs:org.eclipse.jdt.core.formatter.lineSplit=800
bundles/org.eclipse.equinox.cm.test/.settings/org.eclipse.jdt.core.prefs:org.eclipse.jdt.core.formatter.lineSplit=800
bundles/org.eclipse.equinox.cm/.settings/org.eclipse.jdt.core.prefs:org.eclipse.jdt.core.formatter.lineSplit=800
bundles/org.eclipse.equinox.common.tests/.settings/org.eclipse.jdt.core.prefs:org.eclipse.jdt.core.formatter.lineSplit=120
bundles/org.eclipse.equinox.common/.settings/org.eclipse.jdt.core.prefs:org.eclipse.jdt.core.formatter.lineSplit=800
bundles/org.eclipse.equinox.compendium.tests/.settings/org.eclipse.jdt.core.prefs:org.eclipse.jdt.core.formatter.lineSplit=800
bundles/org.eclipse.equinox.coordinator/.settings/org.eclipse.jdt.core.prefs:org.eclipse.jdt.core.formatter.lineSplit=800
bundles/org.eclipse.equinox.device/.settings/org.eclipse.jdt.core.prefs:org.eclipse.jdt.core.formatter.lineSplit=800
bundles/org.eclipse.equinox.event/.settings/org.eclipse.jdt.core.prefs:org.eclipse.jdt.core.formatter.lineSplit=800
bundles/org.eclipse.equinox.http.jetty.starter/.settings/org.eclipse.jdt.core.prefs:org.eclipse.jdt.core.formatter.lineSplit=800
bundles/org.eclipse.equinox.http.jetty/.settings/org.eclipse.jdt.core.prefs:org.eclipse.jdt.core.formatter.lineSplit=800
bundles/org.eclipse.equinox.http.registry/.settings/org.eclipse.jdt.core.prefs:org.eclipse.jdt.core.formatter.lineSplit=800
bundles/org.eclipse.equinox.http.servlet/.settings/org.eclipse.jdt.core.prefs:org.eclipse.jdt.core.formatter.lineSplit=80
bundles/org.eclipse.equinox.http.servletbridge/.settings/org.eclipse.jdt.core.prefs:org.eclipse.jdt.core.formatter.lineSplit=800
bundles/org.eclipse.equinox.io/.settings/org.eclipse.jdt.core.prefs:org.eclipse.jdt.core.formatter.lineSplit=800
bundles/org.eclipse.equinox.ip/.settings/org.eclipse.jdt.core.prefs:org.eclipse.jdt.core.formatter.lineSplit=800
bundles/org.eclipse.equinox.jsp.jasper.registry/.settings/org.eclipse.jdt.core.prefs:org.eclipse.jdt.core.formatter.lineSplit=800
bundles/org.eclipse.equinox.jsp.jasper/.settings/org.eclipse.jdt.core.prefs:org.eclipse.jdt.core.formatter.lineSplit=800
bundles/org.eclipse.equinox.log.stream/.settings/org.eclipse.jdt.core.prefs:org.eclipse.jdt.core.formatter.lineSplit=800
bundles/org.eclipse.equinox.metatype/.settings/org.eclipse.jdt.core.prefs:org.eclipse.jdt.core.formatter.lineSplit=800
bundles/org.eclipse.equinox.preferences/.settings/org.eclipse.jdt.core.prefs:org.eclipse.jdt.core.formatter.lineSplit=800
bundles/org.eclipse.equinox.region.tests/.settings/org.eclipse.jdt.core.prefs:org.eclipse.jdt.core.formatter.lineSplit=120
bundles/org.eclipse.equinox.region/.settings/org.eclipse.jdt.core.prefs:org.eclipse.jdt.core.formatter.lineSplit=800
bundles/org.eclipse.equinox.registry/.settings/org.eclipse.jdt.core.prefs:org.eclipse.jdt.core.formatter.lineSplit=800
bundles/org.eclipse.equinox.security.macosx/.settings/org.eclipse.jdt.core.prefs:org.eclipse.jdt.core.formatter.lineSplit=800
bundles/org.eclipse.equinox.security.tests/.settings/org.eclipse.jdt.core.prefs:org.eclipse.jdt.core.formatter.lineSplit=120
bundles/org.eclipse.equinox.security.ui/.settings/org.eclipse.jdt.core.prefs:org.eclipse.jdt.core.formatter.lineSplit=800
bundles/org.eclipse.equinox.security/.settings/org.eclipse.jdt.core.prefs:org.eclipse.jdt.core.formatter.lineSplit=800
bundles/org.eclipse.equinox.servletbridge/.settings/org.eclipse.jdt.core.prefs:org.eclipse.jdt.core.formatter.lineSplit=800
bundles/org.eclipse.equinox.transforms.hook/.settings/org.eclipse.jdt.core.prefs:org.eclipse.jdt.core.formatter.lineSplit=800
bundles/org.eclipse.equinox.transforms.xslt/.settings/org.eclipse.jdt.core.prefs:org.eclipse.jdt.core.formatter.lineSplit=800
bundles/org.eclipse.equinox.useradmin/.settings/org.eclipse.jdt.core.prefs:org.eclipse.jdt.core.formatter.lineSplit=800
bundles/org.eclipse.equinox.util/.settings/org.eclipse.jdt.core.prefs:org.eclipse.jdt.core.formatter.lineSplit=800
bundles/org.eclipse.equinox.weaving.caching.j9/.settings/org.eclipse.jdt.core.prefs:org.eclipse.jdt.core.formatter.lineSplit=80
bundles/org.eclipse.equinox.weaving.caching/.settings/org.eclipse.jdt.core.prefs:org.eclipse.jdt.core.formatter.lineSplit=80
bundles/org.eclipse.equinox.weaving.hook/.settings/org.eclipse.jdt.core.prefs:org.eclipse.jdt.core.formatter.lineSplit=80
bundles/org.eclipse.equinox.wireadmin/.settings/org.eclipse.jdt.core.prefs:org.eclipse.jdt.core.formatter.lineSplit=800

[2] 

$ git grep org.eclipse.jdt.core.formatter.lineSplit=
bundles/org.eclipse.core.contenttype/.settings/org.eclipse.jdt.core.prefs:org.eclipse.jdt.core.formatter.lineSplit=120
bundles/org.eclipse.core.expressions/.settings/org.eclipse.jdt.core.prefs:org.eclipse.jdt.core.formatter.lineSplit=120
bundles/org.eclipse.core.jobs/.settings/org.eclipse.jdt.core.prefs:org.eclipse.jdt.core.formatter.lineSplit=120
bundles/org.eclipse.core.runtime/.settings/org.eclipse.jdt.core.prefs:org.eclipse.jdt.core.formatter.lineSplit=120
bundles/org.eclipse.core.tools/.settings/org.eclipse.jdt.core.prefs:org.eclipse.jdt.core.formatter.lineSplit=120
bundles/org.eclipse.e4.core.contexts/.settings/org.eclipse.jdt.core.prefs:org.eclipse.jdt.core.formatter.lineSplit=120
bundles/org.eclipse.e4.core.di.annotations/.settings/org.eclipse.jdt.core.prefs:org.eclipse.jdt.core.formatter.lineSplit=120
bundles/org.eclipse.e4.core.di.extensions.supplier/.settings/org.eclipse.jdt.core.prefs:org.eclipse.jdt.core.formatter.lineSplit=120
bundles/org.eclipse.e4.core.di.extensions/.settings/org.eclipse.jdt.core.prefs:org.eclipse.jdt.core.formatter.lineSplit=120
bundles/org.eclipse.e4.core.di/.settings/org.eclipse.jdt.core.prefs:org.eclipse.jdt.core.formatter.lineSplit=120
bundles/org.eclipse.e4.core.services/.settings/org.eclipse.jdt.core.prefs:org.eclipse.jdt.core.formatter.lineSplit=120
tests/org.eclipse.core.contenttype.tests/.settings/org.eclipse.jdt.core.prefs:org.eclipse.jdt.core.formatter.lineSplit=120
tests/org.eclipse.core.expressions.tests/.settings/org.eclipse.jdt.core.prefs:org.eclipse.jdt.core.formatter.lineSplit=120
tests/org.eclipse.core.tests.harness/.settings/org.eclipse.jdt.core.prefs:org.eclipse.jdt.core.formatter.lineSplit=120
tests/org.eclipse.core.tests.runtime/.settings/org.eclipse.jdt.core.prefs:org.eclipse.jdt.core.formatter.lineSplit=120
tests/org.eclipse.e4.core.tests/.settings/org.eclipse.jdt.core.prefs:org.eclipse.jdt.core.formatter.lineSplit=120

~~~
Jonah Graham
Kichwa Coders
www.kichwacoders.com

_______________________________________________
eclipse-dev mailing list
eclipse-dev@xxxxxxxxxxx
To unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/eclipse-dev