Re: [eclipse-dev] Review request flag

[Susan M Franklin <susan_franklin@xxxxxxxxxx>]

One thing I noticed today...
Being a reviewer does not automatically
cc: you, so if there is ongoing discussion about the bug, you need to cc:
the person who you want to review the bug, or else that person should add
their name to the cc: list in order to follow discussion.  In other
words, don't assume that your comments in the bug report will be seen by
the reviewer after they've reviewed the fix.

susan

John Arthorne <John_Arthorne@xxxxxxxxxx> Sent by: eclipse-dev-bounces@xxxxxxxxxxx 05/09/2007 02:44 PM Please respond to "General development mailing list of the Eclipse project."

To:        eclipse-dev@xxxxxxxxxxx         cc:                 Subject:        [eclipse-dev] Review request flag

I just wanted to point out the new flag
fields in bugzilla for those who aren't aware of it.  Now that we're
in the end-game, and all fixes require review, this is an ideal tool to
help teams track the review process. It works as follows:


1) The person asking for a review sets
the "review" flag to "?", and adds an email address
of the person who they want to conduct the review (bugzilla calls it the
"requestee"). 

-> Bugzilla will send an email to
that person asking them to review the bug. 

2) After the reviewer reviews the fix,
they change the review flag from "?" to either "+"
(approved) or "-" (not approved). 

-> Bugzilla sends an email back to
the person who asking for the review, telling them the result.


Once you start using these flags, you
can then do bugzilla queries to help you manage the bugs being reviewed/released.
In the boolean charts section of the query page, use "Flag is equal
to review+" to search for bugs that have been reviewed. For example,
here is a query of all bugs marked RC1 that have been reviewed and FIXED:


https://bugs.eclipse.org/bugs/buglist.cgi?query_format=advanced&short_desc_type=allwordssubstr&short_desc=&classification=Eclipse&target_milestone=3.3+RC1&long_desc_type=allwordssubstr&long_desc=&bug_file_loc_type=allwordssubstr&bug_file_loc=&status_whiteboard_type=allwordssubstr&status_whiteboard=&keywords_type=allwords&keywords=&bug_status=RESOLVED&bug_status=VERIFIED&bug_status=CLOSED&resolution=FIXED&emailtype1=substring&email1=&emailtype2=substring&email2=&bugidtype=include&bug_id=&votes=&chfieldfrom=&chfieldto=Now&chfieldvalue=&cmdtype=doit&order=Reuse+same+sort+as+last+time&field0-0-0=flagtypes.name&type0-0-0=equals&value0-0-0=review%2B


Similarly, use "Flag is equal to
review?" for bugs awaiting review, and "Flag is not equal to
review+" for bugs that have not been reviewed.  This is useful
to help you manage your review queue, and verify that everything has been
reviewed. 

Attached is a screen shot showing the
flags on the bugzilla page. 


_______________________________________________
eclipse-dev mailing list
eclipse-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe
from this list, visit
https://dev.eclipse.org/mailman/listinfo/eclipse-dev


#### capture.png has been removed from this note on
May 09, 2007 by Susan M Franklin