[
Date Prev][
Date Next][
Thread Prev][
Thread Next][
Date Index][
Thread Index]
[
List Home]
|
Re: [ecf-dev] Why does the httpclient4 feature require source bundles?
|
Hi Thomas,
Thanks for the offer of assistance. I can't take this on right away, so
I've opened up bug
On 6/27/2014 11:02 PM, Thomas Hallgren wrote:
Hi Scott,
Sure, I can help. The first step is to create a specific source
feature for the feature in question and then move the source bundles
over to that feature. That way, the p2.core feature (and users of it)
would not automatically include the source. Next step would be for the
feature that really needs the source (the sdk feature?) to include
your new source feature. Or perhaps there's a p2.core.source feature?
In that case it would be the natural place for inclusion of your
source feature.
- thomas
On 2014-06-28 01:06, Scott Lewis wrote:
Hi Thomas,
I checked the git commit records, in the comment I refer to this bug
comment:
https://bugs.eclipse.org/bugs/show_bug.cgi?id=409787#c27
And as I recall there was also a lot of discussion at the time on
source inclusion in bug
https://bugs.eclipse.org/bugs/show_bug.cgi?id=419647
Upshot: It may not have been the best decision for the general case
(non-Eclipse products), but at the time I believe I was thinking of
the Eclipse SDK product needs and trying to get a platform milestone
completed.
With some consulting/assistance from you on the Buckminster needs on
our end (e.g. including these source bundles in our repo, even if not
in the feature) I would be willing to work with the SDK folks to
change things in a future version (ECF has plans for a 3.9.0 release
as soon as OSGi RS/RSA specs are final).
Thanks,
Scott
On 6/27/2014 2:04 PM, Thomas Hallgren wrote:
Hi Scott,
I have a hard time understanding why any product needs to contain
sources from Apache projects. If they were offered in a separate
feature, yeah perhaps, but still, this is not Eclipse source and I
don't see any other features including external sources.
- thomas
On 2014-06-27 18:26, Scott Lewis wrote:
Hi Thomas,
On 6/27/2014 8:45 AM, Thomas Hallgren wrote:
Hi,
I have some problems packaging a product that uses the p2.core
feature. It includes the
org.eclipse.ecf.filetransfer.httpclient4.feature which in turn
includes both source and binary features for a group of org.apache
bundles. Why does this feature include the source bundles?
I think that this was how David/Platform had to configure things
with Tycho in order to get source bundles included for the SDK. See
[1] for the coordination bug wrt feature refactoring.
You also might want to ask David Williams directly (or on
cross-projects, whichever you are most comfortable with).
Scott
[1] https://bugs.eclipse.org/bugs/show_bug.cgi?id=409787
It's really problematic because I can't get rid of them unless I
create a copy of the feature and then also create copy of the
p2.core feature that includes it.
Regards,
Thomas Hallgren
_______________________________________________
ecf-dev mailing list
ecf-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/ecf-dev
_______________________________________________
ecf-dev mailing list
ecf-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/ecf-dev
_______________________________________________
ecf-dev mailing list
ecf-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/ecf-dev
_______________________________________________
ecf-dev mailing list
ecf-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/ecf-dev
_______________________________________________
ecf-dev mailing list
ecf-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/ecf-dev
