Re: [ecf-dev] Small changes to AbstractRemoteServicesTest

[Samolisov Pavel <samolisov@xxxxxxxxx>]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Sorry Scott. I opened bug
https://bugs.eclipse.org/bugs/show_bug.cgi?id=299851 for this and
attached patch for it.

Scott Lewis пишет:
> Hi Pavel,
> 
> These additions and changes all seem great to me.  Please open a bug and
> attach the patch to the bug, and I will apply.
> Just in case people don't already know...the reason it's necessary to
> open a bug is that this is the process we're required to follow for EF
> IP review and permanent tracking/history for patches/contributions.
> 
> Thanks much!!
> 
> Scott
> 
> 
> Samolisov Pavel wrote:
>> Hello folks,
>>
>> I'm working on OSCAR/ICQ provider for Eclipse Communication Framework
>> and implemented Remote Service API via OSCAR/ICQ.
>>
>> I want suggest small changes to AbstractRemoteServicesTest:
>>
>> 1. add assertTrue(done); after waiting to method testServiceListener. If
>> do not check 'done' - test can be passed if even RemoteServiceListener
>> was not be invoked.
>>
>> 2. add protected method customizeProperties and invoked it for
>> customizing register services properties in other bundles. For example
>> in the org.eclipse.ecf.tests.provider.oscar I implemented this method:
>>
>> protected Dictionary customizeProperties(Dictionary props) {
>>     Dictionary result = new Hashtable();
>>     // ...
>>     result.put(Constants.SERVICE_REGISTRATION_TARGETS,
>> getClient(1).getConnectedID());
>>     return result;
>> }
>>
>> If we do not put Constants.SERVICE_REGISTRATION_TARGETS to properties,
>> test testServiceListener will not be passed because
>> adapters[0].registerRemoteService will not send message to
>> containers[1]. ICQ do not support predefined groups and do not send
>> broadcast messages.
>>
>> I attach my patch to this message.
>>
>>  
>> ------------------------------------------------------------------------
>>
>> _______________________________________________
>> ecf-dev mailing list
>> ecf-dev@xxxxxxxxxxx
>> https://dev.eclipse.org/mailman/listinfo/ecf-dev
> 


- --
Pavel Samolisov

Meet me at:
Vkontakte.ru: http://vkontakte.ru/id3178981
Blog: http://samolisov.blogspot.com
Twitter: http://twitter.com/samolisov
XMPP/Jabber: samolisov@xxxxxxxxx
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.11 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAktSCl8ACgkQ20T0Vos3rqC4agCfUdVkAgGwlkTuUixRoIyrp/la
A8cAoLiEfpgIZUnJkUHgreOgUN/PXxhl
=eAm/
-----END PGP SIGNATURE-----