Re: [ecf-dev] Tests

[Scott Lewis <slewis@xxxxxxxxxxxxx>]

Hi Wim,

Wim Jongman wrote:
>     I"m not sure I understand what the purpose of this would
>     be/is...and I don't know enough about 
>
>
> Well, and this triggers another question, we are used to move test 
> code into fragments because they are in the same classloader as the 
> host plugin. This means that we do not have to export internal 
> packages just to have them tested. But, and here is the question, I 
> believe/have seen that eclipse projects _always_ export all  packages. 
> Is this a law/requirement?

I'm frankly not sure on how strictly it is to be taken (any lurker feel 
free to detail)...but I think it is at least a recommendation that all 
packages be exported...and that internal packages be marked with 
x:-internal.  This is what the PDE does, for example, when the PDE 
'organize manifests' refactoring is undertaken.

So we/ECF have been doing this (exporting all packages, and marking 
internal ones as such...e.g.):

Export-Package: org.eclipse.ecf.internal.provider;x-internal:=true,
org.eclipse.ecf.provider.comm,
org.eclipse.ecf.provider.comm.tcp,
org.eclipse.ecf.provider.generic,
org.eclipse.ecf.provider.generic.gmm,
org.eclipse.ecf.provider.util

Just by using the default PDE options for 'organize manifests'.

Scott