Re: [ecf-dev] AbstractShare and IChannel clean-up...

[Remy Chi Jian Suen <remy.suen@xxxxxxxxx>]

Hi Scott,

On Wed, Apr 22, 2009 at 4:46 PM, Scott Lewis <slewis@xxxxxxxxxxxxxxxxx> wrote:
> I think the channel container should call IChannel.dispose() upon
> removeChannel...but you are correct that the implementation based upon the
> shared object API (org.eclipse.ecf.provider.datashare) does not.  I would
> consider this a bug...and I'll assign to myself and fix it for that
> implementation.

Thanks for the clarification. I've opened two bugs, one for the
javadoc update and the other for the SO bug.
https://bugs.eclipse.org/bugs/show_bug.cgi?id=273342
https://bugs.eclipse.org/bugs/show_bug.cgi?id=273343

> The current approach (i.e. limited to one IChannel per
> 'Share'...which represents a two-way active docshare 'session') should
> probably be replace with something that has e.g. an IChannel for
> 'control'...i.e. starting/stopping individual resource sharing...or editor
> sharing, etc...with the use/creation of other IChannel specific protocols
> (e.g. shared editing of a single resource with cola/sync API-based
> synchronization).

Could you rephrase this? Did you mean one channel per "type" of
'Share'? "Type" here being "docshare" wherein all DocShare instances
of provider N would use the same IChannel from provider N?

Remy