Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [eavp-dev] EAVP build questions

Hi Robert,

I have just been granted access to eclipse/january repo this morning
and I am progressing on getting the code into there.

Jonah
~~~
Jonah Graham
Kichwa Coders Ltd.
www.kichwacoders.com


On 22 August 2016 at 15:30, Smith, Robert W. <smithrw@xxxxxxxx> wrote:
> Jay and Jonah,
>
>
> I've made and tested the changes in EAVP. A pull request to January was
> mentioned, but as far as I can see the January repo on Github is empty. I
> assume I should wait for the initial January commit before forking it and
> issuing a pull request from that?
>
>
> Robert
>
> ________________________________
> From: eavp-dev-bounces@xxxxxxxxxxx <eavp-dev-bounces@xxxxxxxxxxx> on behalf
> of Jay Jay Billings <jayjaybillings@xxxxxxxxx>
> Sent: Monday, August 22, 2016 6:32 AM
> To: eavp developer discussions
> Subject: Re: [eavp-dev] EAVP build questions
>
>
> Jonah,
>
> It makes sense to me, but because we didn't nominate him during the creation
> process, he'll have to close a few bugs first or the PMC won't approve it.
> (Closing a few bugs is basically breakfast for Robert. ;))
>
> Jay
>
>
> On Aug 21, 2016 9:18 PM, "Jonah Graham" <jonah@xxxxxxxxxxxxxxxx> wrote:
>>
>> Thanks Jay,
>>
>> I guess the key question answered there is that it shouldn't be there. I
>> was concerned if there was one of those bundles that didn't want to be on
>> the run time deps.
>>
>> As far as committing directly to January, I have raised a bug settings up
>> access permissions for my github.com account for the January project
>> yesterday. I imagine that will be resolved once webmasters get to work
>> Monday.
>>
>> Finally, Robert you are not a committer on January at the moment. As you
>> have authored significant amount of the code, I recommend we submit you as a
>> committer as soon as possible. Jay, does that make sense to you?
>>
>> Jonah
>>
>>
>> On 21 Aug 2016 07:22, "Jay Jay Billings" <jayjaybillings@xxxxxxxxx> wrote:
>>>
>>> Jonah,
>>>
>>> It does essentially the same thing without putting the bundles in the
>>> manifest. It puts them on the class path in the build file instead.
>>>
>>> We shouldn't be using those either. Robert, can you convert all of our
>>> additional bundle statements into import packages please? You could probably
>>> do this directly to January instead of EAVP and I'll merge the pull request.
>>> (That way we don't have to pull from EAVP since we are switching anyway.)
>>>
>>> Jay
>>>
>>>
>>> On Aug 20, 2016 12:11 PM, "Jonah Graham" <jonah@xxxxxxxxxxxxxxxx> wrote:
>>>
>>> Hi EAVP devs,
>>>
>>> I am working on January build/release engineering stuff.
>>>
>>> What does additional.bundles in build.properties[1] do that including
>>> those bundles in the MANIFEST.MF Require-Bundle does not do? I have
>>> never used additional.bundles before, so any clarification would be
>>> most appreciated.
>>>
>>> Thanks,
>>> Jonah
>>>
>>> [1]
>>> https://github.com/eclipse/eavp/blob/next/org.eclipse.january.geometry/build.properties#L25
>>>
>>> ~~~
>>> Jonah Graham
>>> Kichwa Coders Ltd.
>>> www.kichwacoders.com
>>> _______________________________________________
>>> eavp-dev mailing list
>>> eavp-dev@xxxxxxxxxxx
>>> To change your delivery options, retrieve your password, or unsubscribe
>>> from this list, visit
>>> https://dev.eclipse.org/mailman/listinfo/eavp-dev
>>>
>>>
>>>
>>> _______________________________________________
>>> eavp-dev mailing list
>>> eavp-dev@xxxxxxxxxxx
>>> To change your delivery options, retrieve your password, or unsubscribe
>>> from this list, visit
>>> https://dev.eclipse.org/mailman/listinfo/eavp-dev
>>>
>>
>> _______________________________________________
>> eavp-dev mailing list
>> eavp-dev@xxxxxxxxxxx
>> To change your delivery options, retrieve your password, or unsubscribe
>> from this list, visit
>> https://dev.eclipse.org/mailman/listinfo/eavp-dev
>>
>
> _______________________________________________
> eavp-dev mailing list
> eavp-dev@xxxxxxxxxxx
> To change your delivery options, retrieve your password, or unsubscribe from
> this list, visit
> https://dev.eclipse.org/mailman/listinfo/eavp-dev
>


Back to the top