Re: [dirigible-dev] New Tutorial - Custom Language Support

["Pavlov, Yordan" <yordan.pavlov@xxxxxxx>]

Hi Nedelcho,

The tutorial is great!

It is simple, straightforward and easy to understand.

Feedback:

• For each step, you can give a link to the exact changes in GitHub. For example:
  • SQLExecutor: https://github.com/eclipse/dirigible/commit/30a85e9c4420ab71176ba1cb0ab5e1047442f0e3#diff-066da496886b8184282466c3bdec6c69
  • SQLServlet: https://github.com/eclipse/dirigible/commit/30a85e9c4420ab71176ba1cb0ab5e1047442f0e3#diff-5a4e19ad3e2f8b272f0edb4818bcc36b
  • web.xml: https://github.com/eclipse/dirigible/commit/30a85e9c4420ab71176ba1cb0ab5e1047442f0e3#diff-7afdca0b486406433a2d047b4ef9c68c
  • …
• There is one variable that is never used in the "SQLExecutor" class - "classpath"
• There is no code for the following classes:
  • org.eclipse.dirigible.runtime.sql.SQLServlet.java
  • org.eclipse.dirigible.runtime.sql.SQLSandboxServlet.java
  • org.eclipse.dirigible.runtime.sql.SQLSecuredServlet.java
  • org.eclipse.dirigible.runtime.sql.SQLScriptExecutorProvider.java

Regards,

Yordan

From: <dirigible-dev-bounces@xxxxxxxxxxx> on behalf of Nedelcho Delchev <nedelcho.delchev@xxxxxxx>
Reply-To: "dirigible-dev@xxxxxxxxxxx" <dirigible-dev@xxxxxxxxxxx>
Date: Wednesday, October 21, 2015 at 10:29 PM
To: "dirigible-dev@xxxxxxxxxxx" <dirigible-dev@xxxxxxxxxxx>
Subject: [dirigible-dev] New Tutorial - Custom Language Support

Hi Team,

Just to share a new tutorial about creating a custom plugin for SQL language support in Dirigible. The idea is to be used also as an additional material for EclipseCon, hence any feedback and comments are very much appreciated.

http://www.dirigible.io/blogs/2015/10/21/blogs_dirigible_impl_sql_plugin.html

Regards,
Nedelcho