Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [che-dev] User Devfiles

Looks good. 

A couple of comments: 
1) Having a version for the factory and a version for the devfile looks confusing
2) The name "factory" doesn't makes sense anymore. We could rename it userDevfile.

On Fri, May 15, 2020 at 4:41 PM Sergii Kabashniuk <skabashn@xxxxxxxxxx> wrote:


On Fri, May 15, 2020 at 4:15 PM Sergii Kabashniuk <skabashn@xxxxxxxxxx> wrote:
Hello, devs.
I would like to share some insights about User Devfiles [1]
As some of you probably knows we start progressing on this [2] in the current sprint.
The plan is to adapt Che6 [3] factories to use Devfiles.
And I would like to share some of Che Platform team and my thoughts on this.
At this moment Factory object looks like this:

factory : {
  "v"         : 4.0,            (1)
  "workspace" : {},             (2)
  "policies"  : {},             (3)
  "ide"       : {},             (4)
  "creator"   : {},             (5)
}

We would like to:
1: keep the version. Increase number from 4.0 to 5.0
2. workspace - replaced with devfile. Same object as it used in Workspace API
3. policies - remain untouched
4. ide -  to remove it, since this is going to be addressed in Devfile 2.x
5. create - remain untouched

Any opinions about that?
links 

[1] User Devfiles https://github.com/eclipse/che/issues/16875
[2] Adapt persistent factories to Devfile concept https://github.com/eclipse/che/issues/16897

--

Sergii Kabashniuk

Principal Software Engineer, DevTools 

Red Hat

skabashniuk@xxxxxxxxxx    



--

Sergii Kabashniuk

Principal Software Engineer, DevTools 

Red Hat

skabashniuk@xxxxxxxxxx    

_______________________________________________
che-dev mailing list
che-dev@xxxxxxxxxxx
To unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/che-dev

Back to the top