Skip to main content
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [che-dev] Stale branches in che repos :: ACTION REQUIRED :: please take out your trash :D
I guess the answer is in the question - the reason is collaboration and visibility, which for Open Source are default patterns. And I would consider it as quite important thing. For example: being not a community member but 

While I understand the attractiveness of using forks for individual coding (and I believe no one force not to use them), as it stated in github help [1]: "Most commonly, forks are used to either propose changes to someone else's project or to use someone else's project as a starting point for your own idea."
Note: "someone else's project" is a main case of using it. 

FWIW: It took just about 15 minutes of time to find ones who had stalled branches and ask everyone personally. You can see the result [2] 
Maybe we need to make it a part of triaging or so exercise instead of inventing tricky "branch vs fork policy"? :)

Thanks,
Gennady

[2] https://github.com/eclipse/che/branches/stale

On Tue, Feb 18, 2020 at 10:47 AM Sergii Kabashniuk <skabashn@xxxxxxxxxx> wrote:
What I didn't understand is why do you forcing someone to do things in the way you like to do without strong technical reasons?
Why we are ignoring diversity and pushing everybody to work in the way how the mainstream is doing?
Is there a technical reason why we should not allow some contributors to collaborate in the way how they used to do that for years?

I proposed to move this conversation in a less strict tone.
1. Propose the recommended way to do the contribution.
2. Propose the recommended way for branch names.
3. Encourage people to clean up after the work has been done.



On Tue, Feb 18, 2020 at 9:31 AM Thomas Mäder <tmader@xxxxxxxxxx> wrote:

What I don't understand in the whole discussion is why someone would object to working in their own fork. There is really not downside to it: if you want to start collaborating with someone else, you can just push the branch to the main repo. Otherwise the workflow is exactly the same as if you created your branch in the main repo. Can someone enlighten me?

/Thomas

On 17/02/2020 17:19, Sun Tan wrote:
hey,
I have created this survey:


Sun Tan

Senior Software Engineer

Eclipse Che - CodeReady Workspaces @ Red Hat
Paris JUG leader

Red Hat Paris

sutan@xxxxxxxxxx    
M: +33621024173    


On Thu, Feb 13, 2020 at 9:22 AM Radim Hopp <rhopp@xxxxxxxxxx> wrote:
OMG! Big +1 to this. I've been trying to convince people to start using forks and keep upstream "celan" for some time now... 

On Thu, Feb 13, 2020 at 9:18 AM Michal Vala <mvala@xxxxxxxxxx> wrote:
yes please, do the work in personal fork is imho right way to go on github. I would even disable creating branches upstream so we don't have a mess like this and each `git fetch` downloads 10 new random branches.

On Thu, Feb 13, 2020 at 8:59 AM Thomas Mäder <tmader@xxxxxxxxxx> wrote:

I do my my work (unless I need to cooperate with others) on my personal fork of said projects. Is there any reason not to? Maybe we should adopt this as a good practice.

/Thomas

On 12/02/2020 17:11, Nick Boldt wrote:
Just a reminder to committers that your merged PR branches and old topic branches from closed issues should be purged from the origin repo to keep it clean.

Please take a few minutes to delete your old branches. I've done so for che-plugin-reg and che-devfile-reg if the branch was marked merged, but there are many more.

https://github.com/eclipse/che/branches/stale for example has two pages of deletable topic/PR branches, including some pre-7.0 branches which we probably don't need anymore as we're never going to patch those releases.

etc.

Thanks!

--

Nick Boldt

Principal Software Engineer, RHCSA

Productization Lead :: CodeReady Workspaces 

IM: @nickboldt / @nboldt / http://nick.divbyzero.com

Back to the top