Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [che-dev] Che Theia user preferences synchronization between Che workspaces demo

Fair point Gorkem. I'm a big fan of prioritization and my point wasn't high priority :)

On Tue, Feb 26, 2019 at 11:17 AM Gorkem Ercan <gorkem.ercan@xxxxxxxxx> wrote:
I do not think this a feature that is worth the trouble.
 It is not a big inconvenience to restart a workspace. We can come back to it when we fried all the bigger fish :)

On Tue, Feb 26, 2019 at 11:04 AM Mykola Morhun <mmorhun@xxxxxxxxxx> wrote:
Thank you Brad for your remark.
To be able to persist Theia user preference we use field in Che user preferences as a storage. But it doesn't have any onchange notifications (as far as I know, and it is not even designed to do so). So we just cannot know when a preference changes with current Che API. (Well, we can query preferences each, say 10 seconds, but it is very inefficient, so I didn't consider it as a way to go). The right way might be to make modification in Che API. But it is a REST and adding something like event subscription kinda breaks pattern to me. Anyway it is a huge issue and should be discussed probably in this mail list, when the task will be taken in a sprint.
And there is no "save" button in Theia preferences, I treat a change without syntax error as a save action.


On Tue, Feb 26, 2019 at 5:32 PM Brad Micklea <bmicklea@xxxxxxxxxx> wrote:
Wouldn't it be useful / possible to have the updated preferences "distributed" to other running workspaces when a user hits the preference save/apply button?

On Tue, Feb 26, 2019 at 8:41 AM Mykola Morhun <mmorhun@xxxxxxxxxx> wrote:
Hello.
Here is my demo about Che Theia user preferences synchronization between Che workspaces:

A few notes on the demo:
 - Actual Theia user preferences synchronization into workspace happens on Che Theia start. So, it will keep up to date existing workspaces as well as newly created. But it will not bring a preference into running workspace from another running one.
 - Che Theia replaces default Theia user preferences on each valid preferences edit (it could be done from the IDE or manually in preferences json).
 - If user needs to configure each project separately it could be reached using Theia workspace preferences (values form Theia user preferences, if any, will be overridden for this particular project).


--

Mykola Morhun

SOFTWARE ENGINEER

Red Hat

_______________________________________________
che-dev mailing list
che-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://www.eclipse.org/mailman/listinfo/che-dev


--
Brad Micklea // Group Lead, Developer Tools & Program // 416.707.0792 
_______________________________________________
che-dev mailing list
che-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://www.eclipse.org/mailman/listinfo/che-dev


--

Mykola Morhun

SOFTWARE ENGINEER

Red Hat

_______________________________________________
che-dev mailing list
che-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://www.eclipse.org/mailman/listinfo/che-dev
_______________________________________________
che-dev mailing list
che-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://www.eclipse.org/mailman/listinfo/che-dev


--
Brad Micklea // Group Lead, Developer Tools & Program // 416.707.0792 

Back to the top