| Re: [che-dev] PHP related PR waiting for review |
Good catch on the project page. We do not really maintain that - we assume that everyone starts their research of Che on our github repository, so we spend most of our time checking those links. I've updated the project page to have a good link to the wiki.We hired a new PM about 2 months ago - right at the time that the minutes stopped appearing. The new PM is our release manager, and in the transition of duties, it looks like weekly che meeting minutes were not being captured. But we hvae the meeting every week, and people from all across join. Brad - see below - we are missing meeting minutes for the past 6 meetings.The process can be elaborated upon in the wiki. We only accept PRs that are merge ready. But we still a maintainer to accept it into their sprint. We have many PRs - including many that we have drafted - that haven't gotten taken into the sprint. There have been a number of commitments that we have had to make to the market, and there were deliverables up through September that took precedence. The maintainers that are responsible for project types & the IDE were asked to prioritize getting the language server protocol completed before considering the PHP stuff.If you want to send some ire or frustration, you can send it to me, as I personally set the priorities for the TLs within each sprint. But we do document the intended milestone plan (sprint plan) in advance with the sprint/next-sprint label, and we also keep a complete list of the expected work items for a particular group. The gropu that you care about is the team/ide group. But I gave them priorities related to some long time bug fixes and language server protocol before considering the PHP items. I added these PHP items into the epic tracking for phase 1 language server.We have accepted about 100 PRs from the community this year. We usually prioritize them near the top of the stack, unless we believe there is QA or other infrastructure epics that need to be completed first before we consider the PR. For example, there is a long running pair programming plugin PR and a long running test runner (Junit) support PR that has been in our backlog. But we cannot merge both of these until we had fixed other things related for virtual file systems, maven bugs, and the so forth. We discuss these items in the weekly meetings and in the milestone plans.Any time a developer gets two major PRs merged in and they are participating in the docs / support forums, we nominate them for committer status. We have done that with people from SAP & Red Hat this year. Just 2 days ago, Mario Loriedo from RHT got nominated for committer. He is now the technical lead for a team of 5 people from Red Hat who are working on Che. I hope that all 5 of them are committers before the end of the year.But this is a very complicated system. And we do not just merge PRs from the community. We do want a TL to take it into the sprint, add it into our integration tests, verify docs, communicate with the PR submitter, and verify that we have a long term plan for support. So even small quick fixes like the one liner - yes those are easy. But I told the engineers to package that up with the PHP PT and the language server because they were co-related and should be released & shipped together.
Tyler Jewell | CEO | tyler@codenvy.
com | 978.884.5355 On Wed, Sep 14, 2016 at 12:11 PM, Kaloyan Raev <kaloyan.r@xxxxxxxx> wrote:Hi Tyler,
Thanks for pointing me to the correct wiki. Please note that the Che project page [1] points to an outdated wiki [2]. Perhaps, you would want to remove [2] and update [1] to the correct one.
I found the Weekly Planning Meetings wiki page [3]. There the last documented meeting is from July 19. Are these meetings still happening?
I also read about the dev process [4]. If the process was really followed both PRs should have already been merged.
Quote:
> For the immediate upcoming milestone, we will only accept features who have a pending pull request which has been tested and ready for merge. This will allow the entirety of the iteration to be dedicated to hardening the system and resolving any infrastructure or regressions that appear. Che maintainers may optionally accept pull requests that are initiated during a milestone if they are deemed to have a low risk to destabilizing the code base for the release.
It's hard to imagine a simpler and lower risk feature than #2160 and simpler and lower risk bugfix than #2263. They haven't been even triaged. So, it seems to be a matter of priority given to community contributions.
Also note that my team is in an early stage of introducing PHP support in Che. Our first goal is to estimate the realistic effort for providing a complete PHP support. If a simple one-liner PR waits for weeks and months then, I am afraid, the estimation won't be viable enough for a positive investment decision.
If the Che project wants to grow the community base, it should give higher priority for community contributions, build a diverse committers base, and adapt the dev process to involve the non-Codenvy committers.
[1] https://projects.eclipse.org/projects/ecd.che
[2] https://wiki.eclipse.org/Che
[3] https://github.com/eclipse/che/wiki/Weekly-Planning-Meetings
[4] https://github.com/eclipse/che/wiki/Development-Process
Kaloyan
On 09/14/2016 06:49 PM, Tyler Jewell wrote:
We are working to keep all the details on the entire dev process documented here:
We have had problems in the past with early merges that destabilize the system - so PRs are not merged until a team lead + QA engineers are allocated into a sprint for review, documentation consideration, test, and maintenance plan confirmed. So even simple PRs still have to be scheduled in. It's not very quick, but it is a more stable process.
Tyler
Tyler Jewell | CEO | tyler@codenvy.
com | 978.884.5355
On Wed, Sep 14, 2016 at 8:10 AM, Kaloyan Raev <kaloyan.r@xxxxxxxx> wrote:
Hi Tyler,______________________________
Can you give any info about "the weekly Tuesday sessions" where "the planning conversations for current and upcoming sprints occur". I don't find any info about them. They are also not mentioned in the CONTRIBUTING document: https://github.com/eclipse/che/blob/master/CONTRIBUTING.md
I don't really understand your comment that these PR require more work to be done in order to be merged. If anything blocks them from merging, please add a comment in the respective PR.
Note that #2263 is a very simple change. I don't think it requires anything else to be merged.
Thanks,
Kaloyan
On 09/14/2016 04:35 PM, Tyler Jewell wrote:
We do all of our planning around issues & pull requests to be taken in GitHub. Please make sure that your pull requests are up to date with your timing and requests. The planning conversations for current and upcoming sprints occur on the weekly Tuesday sessions.
We hope to burn down open PRs before our 5.0.0 GA release this fall.
On PHP - there will need to be templates, default commands, and a review of stacks. So accepting the PRs drags along other work to be done.
Tyler Jewell | CEO | tyler@codenvy.
com | 978.884.5355
On Wed, Sep 14, 2016 at 4:09 AM, Kaloyan Raev <kaloyan.r@xxxxxxxx> wrote:
Hi,
We have a couple of pull requests related to PHP support:
- Basic PHP plugin: https://github.com/eclipse/che/pull/2160
- Enable syntax highlighting for *.phtml files: https://github.com/eclipse/che/pull/2263
We will appreciate if they are reviewed and merged.
Thanks,
Kaloyan Raev | Zend Studio Team Lead
Rogue Wave Software, Inc.
Accelerating Great Code
M +359 887 648 663
www.roguewave.com / kaloyan.raev@xxxxxxxxxxxxx
_______________________________________________
che-dev mailing list
che-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/che-dev
_______________________________________________ che-dev mailing list che-dev@xxxxxxxxxxx To change your delivery options, retrieve your password, or unsubscribe from this list, visit https://dev.eclipse.org/mailma n/listinfo/che-dev -- Kaloyan Raev | Zend Studio Team Lead Rogue Wave Software, Inc. Accelerating Great Code M +359 887 648 663 www.roguewave.com / kaloyan.raev@xxxxxxxxxxxxx_________________ che-dev mailing list che-dev@xxxxxxxxxxx To change your delivery options, retrieve your password, or unsubscribe from this list, visit https://dev.eclipse.org/mailma n/listinfo/che-dev _______________________________________________ che-dev mailing list che-dev@xxxxxxxxxxx To change your delivery options, retrieve your password, or unsubscribe from this list, visit https://dev.eclipse.org/mailma n/listinfo/che-dev -- Kaloyan Raev | Zend Studio Team Lead Rogue Wave Software, Inc. Accelerating Great Code M +359 887 648 663 www.roguewave.com / kaloyan.raev@xxxxxxxxxxxxx
_______________________________________________
che-dev mailing list
che-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/che-dev