Re: [che-dev] Che git Interface addition - new Git commands

["Cohen, Dror" <dror.cohen@xxxxxxx>]

Hi Sergii,

 

Thanks for your response.

I will proceed with the contribution according to your recommendations.

 

Regards,

Dror

 

From: che-dev-bounces@xxxxxxxxxxx [mailto:che-dev-bounces@xxxxxxxxxxx] On Behalf Of Sergey Leschenko
Sent: Thursday, October 08, 2015 4:03 PM
To: che developer discussions <che-dev@xxxxxxxxxxx>
Subject: Re: [che-dev] Che git Interface addition - new Git commands

 

Hi Dror,

 

As for the checkout, we decided that it is better to rename and extend current API of branchCheckout.

 

As for the RepositoryState, we ready to put this object here, but only if you implement this for the native git. Otherwise you will need to put it in some inner API of jgit implementation.

 

Regards,

Sergii

 

 

On Thu, Oct 8, 2015 at 12:21 PM, Cohen, Dror <dror.cohen@xxxxxxx> wrote:

Hi Sergii,

First, thanks for you quick reply J

 

BranchCheckout – Git interface seems to support only branch checkout and not restore of working files, since BranchCheckoutRequest API does not hold file paths to be checkout out. Look for this git option git checkout [-p|--patch] [<tree-ish>] [--] <pathspec>…​  

Here: https://git-scm.com/docs/git-checkout

So, Either rename to checkout and extend the API to hold file paths or create a separate checkout command….

 

Status -

Basically I was looking for a place to retrieve the RepositoryState (as shown here: org.eclipse.jgit.internal.JGitText.RepositoryState)

I could not find another Git Command API which retrieved this, so I thought to insert into Git Status…

Other ideas/solutions?

 

Thanks and Regards,

Dror

 

 

From: che-dev-bounces@xxxxxxxxxxx [mailto:che-dev-bounces@xxxxxxxxxxx] On Behalf Of Sergey Leschenko
Sent: Thursday, October 08, 2015 11:57 AM
To: che developer discussions <che-dev@xxxxxxxxxxx>
Subject: Re: [che-dev] Che git Interface addition - new Git commands

 

Hello Dror,

 

Checkout

    We already have command equals to checkout but it's called branchCheckout. I think we can rename branchCheckout to checkout.

 

Rebase

    +1 Why not. It is great command and it will be nice to implement it.

 

Status
    What does mean RepositoryState? Can you explain this please?

 

LogRequest

    Makes sense +1

 

Regards,

Sergii

 

On Thu, Oct 8, 2015 at 11:04 AM, Cohen, Dror <dror.cohen@xxxxxxx> wrote:

Hi All,

 

While developing our JGit implementation under Che 3.12.5 I've noticed some missing Git commands from the GitConnection interface:

·         Checkout

·         Rebase

 

Would you be interested in a contribution adding these commands to the interface?

 

Also, in some small additions to existing command interfaces (requests and responses)?

·         Status
add getRepositoryState() and setRepositoryState(RepositoryState repositoryState) methods

·         LogRequest
add set/getRevisionRangeSince() and set/getRevisionRangeUntil() methods to handle revision range

 

 

Regards,

Dror

_______________________________________________
che-dev mailing list
che-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/che-dev

 

_______________________________________________
che-dev mailing list
che-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/che-dev