Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
[che-dev] Static import

I would like to ask community for their opinion about static import.
Initial discussion was started from this PR  https://github.com/codenvy/che-core/pull/132 

It's made around this rule 
http://checkstyle.sourceforge.net/config_imports.html#AvoidStaticImport

As for me currently I'm about 50/50 
Yes. sometimes it can cause some problems but generally it makes code shorter and more readable.

This check is not enabled in  Google or Sun checkstyle.
https://github.com/checkstyle/checkstyle/blob/master/src/main/resources/google_checks.xml

https://github.com/checkstyle/checkstyle/blob/master/src/main/resources/sun_checks.xml
It's only available in very strict general checkstyle.

So I would say to vote we have 2 option.

1. We require not to use static import.
2. It's up to developer should he use it or not.

Sergii Kabashniuk

PS 
I vote 2 at this moment.


Back to the top