Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [che-dev] Question regarding che-plugin-git-server

Hello Sergii,

 

Making che-git-server reusable is a good solution in my opinion. But changing the packaging type is not enough to make this component reusable: also guice servlet and filter bindings have to be updated with values different from “/*” and this needs a small refactoring.

 

Thanks

Regards,

Alexander

 

From: che-dev-bounces@xxxxxxxxxxx [mailto:che-dev-bounces@xxxxxxxxxxx] On Behalf Of Sergii Kabashniuk
Sent: Wednesday 24 June 2015 11:47
To: che developer discussions
Subject: Re: [che-dev] Question regarding che-plugin-git-server

 

Hello Alexander

The main motivation to package git server as war was: to decouple core api and git-server based on jgit. Main reason was instability of jgit in some cases. Like thread or memory or cpu leak. We are NOT recommend  to put it in the same package and server with platform-api. In the same time if you are confident with your way we can make che-plugin-git-server as jar(I can do that when I will move plugin-git to che-core) so you can reuse it in any place you want. Is that the way you want to go?

 

Sergii Kabashnyuk

 

On Tue, Jun 23, 2015 at 6:12 PM, Bolshakov, Alexander <alexander.bolshakov@xxxxxxx> wrote:

Hello Che developers,

 

I have a question about che-plugin-git-server project: it is packaged as WAR and meant to be standalone webapp, what is the motivation for this? We would like to embed git server functionality into platform-api assembly, which is not possible with current implementation. Would PR splitting this project into 2 JAR and WAR packaged projects be acceptable?

 

Best Regards,

 

Alexander Bolshakov

Developer

Cloud Expirience DevX DI Core

SAP Labs Israel Ltd. 15 Hatidhar St. Ra'anana 43665 Israel

Tel: +972 9 7779677 ; Mobile: +972 54 927546 ; Fax: +972 7 47609677

 


_______________________________________________
che-dev mailing list
che-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/che-dev

 


Back to the top