Re: [che-dev] [che-core] Adding environment variables support to Builder

["Shapiro, Dany" <dany.shapiro@xxxxxxx>]

Hi,
Additional alternative solution can be to "piggy back" the BuilderConfiguration object .
i.e the createCommandLine will update the configuration internally (in additional field ) and when the 
configuration is passed to execute(...) and then to createTaskFor (...) the processBuilder will be updated from configuration using updateEnvironmentVariables(..) that i will change to private.

Do you prefer this solution ?
If you have other ideas , do tell ...

BR.
Dany.

 

 

From: Sergii Kabashniuk [mailto:notifications@xxxxxxxxxx]
Sent: Monday 15 June 2015 15:15
To: codenvy/che-core
Cc: Shapiro, Dany
Subject: Re: [che-core] Adding environment variables support to Builder.class (#115)

 

Can we do that without exposing additional method ?
public Map updateEnvironmentVariables(Map env)

—
Reply to this email directly or view it on GitHub.