Skip to main content
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [che-dev] JGit
Hello
As you mention "It's not impossible". Right now I don't see any blockers that you can't implement with native git.

We are not consider JGit as an option for hosted version. At least because number of testers and users JGit vs Native git are not comparable at all.
Which leads to the issues that we have on production. And we don't want to repeat it again.

But in the same time we opened for other implementations like JGit based for some other use cases.


Sergii Kabashniuk

On Sun, Mar 29, 2015 at 6:45 PM, TAN Sun Seng David <sun.tan@xxxxxxxxx> wrote:
Hi,

OK I didn't have a look in details to JGit, but with the native git used by the GUI, we have some issues

I will take 3 examples

1. Merge conflict using git pull
When you "git pull" and have conflicts, it ask you to solve the conflicts (git add) and continue with (git commit). With the current implementation, it's not possible as you can't perform the command "git commit" without options ....
With JGit you can detect that you are in a "conflict" state and suggest the right resolution step in the UI.

2. conflict while rebasing
It doesn't exist in the Git plugin but if you use git rebase it will ask you to solve conflicts and do actions: git rebase --continue after solving conflicts, or git rebase --abort to cancel. In both case, you will be stuck, and it's hard to handle that situation by embedding Git.
In Eclipse IDE (using JGit) it handles the conflicts properly: asking me in the UI the actions to do. I guess there are some handlers behind it: easier to detect and to handle with Java.

3. push is asking for passphrase ... but not handle by UI
Usually i prefer using ssh key with passphrase. But using the native git command, it will ask my passphrase in the console ... not in the Web UI ...

Git native command is good when using it as a CLI. A lot of git commands needs interaction and is part of a global workflow. It's not impossible, but it's harder to deal with these cases with a embeded native git client.




Le 25/03/2015 15:56, Sergii Kabashniuk a écrit :
Sorry that was fast response. :)
For instance it was very surprised to see 200Mb files in his history.
And this use case was not the last.


Can you elaborate more about what are you missing for git conflict resolving?



On Wed, Mar 25, 2015 at 4:52 PM, Sergii Kabashniuk <skabashnyuk@xxxxxxxxxxx> wrote:
Hello

The main issue with jgit - is that we don't trust it. It was made by normal developers for normal developers.

On Wed, Mar 25, 2015 at 4:43 PM, Sun Tan <sun.tan@xxxxxxxxx> wrote:
Hi all,
The problem by using the command line version of git is that we can hardly handle the interactive side of it: for instance if you do a git pull or merge or rebase, and get into conflict issue, it's hard to solve the conflicts at the moment with the current implementation of Che.

Is the problem only for clone ? maybe we could have a mixed usage:
- command line for clone
- jgit for other actions

Cheers,
Sun

2015-03-24 21:20 GMT+01:00 Sergii Kabashniuk <skabashnyuk@xxxxxxxxxxx>:
See attachments


On Tue, Mar 24, 2015 at 10:13 PM, Tyler Jewell <tyler@xxxxxxxxxxx> wrote:
@Sergii - do we have any old test sequences or selenium tests that offer algorithms for reproducing the issues?

Tyler Jewell | CEO | tyler@​codenvy.​com | 9 ​78​.8​84​.53​ 55

On Tue, Mar 24, 2015 at 12:43 PM, Sergii Kabashniuk <skabashnyuk@xxxxxxxxxxx> wrote:


On Tue, Mar 24, 2015 at 9:28 PM, Sharav, Omer <omer.sharav@xxxxxxx> wrote:

Hi CheDev’s,

 

I understand that you saw some issues when trying to integrate JGit into Che, which led to using the Git binary instead.

We at SAP know a colleague who is contributing to JGit and would be interested to investigate the issues you encountered with regards to the JGit integration.

 

Would you be able to tell us how to recreate the integration (e.g. in which release was it present)?

 
It was in IDE2(Not in current codebase)
We are not recommended to use JGit. It's was extremely unpredictable with concurrent operations like clone in projects larger when "hello world"
From our experience git causes endless operation with 200% CPU usage  lots of times.


Sergii Kabashniuk

 

Thanks!

Omer Sharav.

SAP.


_______________________________________________
che-dev mailing list
che-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/che-dev



_______________________________________________
che-dev mailing list
che-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/che-dev



_______________________________________________
che-dev mailing list
che-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/che-dev



_______________________________________________
che-dev mailing list
che-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/che-dev



_______________________________________________
che-dev mailing list
che-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/che-dev





_______________________________________________
che-dev mailing list
che-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/che-dev


_______________________________________________
che-dev mailing list
che-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/che-dev


Back to the top