Re: [cargotracker-dev] New Liberty branch for EE10

[Reza Rahman <reza_rahman@xxxxxxxxx>]

I'll take a look. I am traveling this week but should be able to provide some feedback after that. At this point, please work towards merging to master.

On 9/12/2023 9:12 AM, Gilbert Kwan wrote:

Hi Reza,

I created the PR https://github.com/eclipse-ee4j/cargotracker/pull/283. If not merge to the master branch, I suggest creating a new branch liberty-ee10.

 

Thanks

Gilbert

 

From: reza_rahman@xxxxxxxxx <reza_rahman@xxxxxxxxx>
Date: Friday, September 8, 2023 at 7:33 PM
To: Gilbert Kwan <gkwan@xxxxxxxxxx>, cargotracker-dev@xxxxxxxxxxx <cargotracker-dev@xxxxxxxxxxx>
Subject: [EXTERNAL] Re: New Liberty branch for EE10

Please work towards contributing to the master branch via a PR. From: Gilbert Kwan <gkwan@ ca. ibm. com> Sent: Friday, September 8, 2023 5: 46 PM To: cargotracker-dev@ eclipse. org <cargotracker-dev@ eclipse. org>; reza_rahman@ lycos. com

ZjQcmQRYFpfptBannerStart

This Message Is From an Untrusted Sender

You have not previously corresponded with this sender.

    Report Suspicious    ‌

ZjQcmQRYFpfptBannerEnd

Please work towards contributing to the master branch via a PR.

 

---

From: Gilbert Kwan <gkwan@xxxxxxxxxx>
Sent: Friday, September 8, 2023 5:46 PM
To: cargotracker-dev@xxxxxxxxxxx <cargotracker-dev@xxxxxxxxxxx>; reza_rahman@xxxxxxxxx <reza_rahman@xxxxxxxxx>
Subject: New Liberty branch for EE10

 

Hi Reza,

The liberty-experimental branch was created for CargoTracker Java EE 8 running with Open Liberty. Now, I would like to contribute the change for CargoTracker Jakarta EE 10 with Open Liberty. The change is available on a new branch of my fork. I assume that, similarly, this may need a new branch (e.g. liberty-experimental-ee10) on the official eclipse-ee4j/cargotracker repo. Should I create a PR against the master branch, and you will handle it? Or would you create a new branch first, then I create the PR?

Thanks

Gilbert