Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
RE: [birt-dev] Checkin:Refactor preview action related codes on GUI

Also remove /org.eclipse.birt.report.designer.ui.preview/src/org/eclipse/birt/report/designer/ui/actions/PreviewAction.java

in this refactor.


From: Hongchang Lin
Sent: Thursday, September 28, 2006 2:07 PM
To: birt-dev@xxxxxxxxxxx
Cc: Qiangsheng Wang; Hongchang Lin
Subject: [birt-dev] Checkin:Refactor preview action related codes on GUI

 

Summary Refactor preview action related codes on GUI

Bugzilla Bug (s) Resolved

Description

Engine has supported to obtain extended output formats contributed by emitters, so preview action and menus on GUI don't need to hard code any emitter's format. Preview menus have been modified to support output format extension in fixing bug 146517.

This refactor has done three parts
1.Remove PreviewAction.java;
2.Move the preview method locats in PreviewAction.java to PreviewToolbarMenuAction.java and PreviewCascadingMenuGroup.java respectively.
3.Enable the preview toolbar menu and preview cascading menu group if report template is opened on editor.

NOTE!

1.In previous PreviewAction.java, preview in PDF needs to check the "com.lowagie.itext" is included in BIRT firstly. Now we think GUI doesn't need to do any check for emitters. Towards this case, PDF emitter should be responsible to response if required resources is missed.
2.Some hard coded behaviors still remain because the icon for preview menu needs to be appointed according to format, towards this issue, a bug is reported to engine, suggest to define a attribute for icon on emitter extending point. And if this suggestion is adopted, refactor is likely required once more.

Tests Description Manual test and code review.

Notes to Build Team

Notes to Developers
Please take this refactor into account when fixing bug 159063

Notes to QA

Notes to Documentation

Files Added



Files Edited

/org.eclipse.birt.report.designer.ui.preview/src/org/eclipse/birt/report/designer/ui/actions/PreviewCascadingMenuGroup.java
/org.eclipse.birt.report.designer.ui.preview/src/org/eclipse/birt/report/designer/ui/actions/PreviewToolbarMenuAction.java

 

Hongchang Lin


Back to the top