[
Date Prev][
Date Next][
Thread Prev][
Thread Next][
Date Index][
Thread Index]
[
List Home]
|
Re: [babel-dev] tapiji patches - whitespace errors
|
Hi Stefan,
Thanks for asking.
We only require that you do not commit additional features at the same
time you commit approved code, since the provenance of the new features
becomes unclear. In this case, whitespace doesn't count since it does
not affect the actual code. Personally, I would prefer b) but please
proceed with a) or b) as you'd like. It doesn't matter.
In terms of coding guidelines, you are free to follow those set forth by
the Eclipse Platform project:
http://wiki.eclipse.org/Development_Conventions_and_Guidelines
These are simply guidelines, however, and nothing there is strictly
enforced. Eclipse committers are implicitly known as the best
programmers in the world, and everyone knows the new code you commit to
our repositories is high quality :-)
Thanks,
Denis
On 11/06/2012 09:36 AM, Stefan Strobl wrote:
Hi
when preparing the commits of our two patches we discovered that git
reports a significant amount of whitespace errors. Unfortunately this
only appeared now as we tested the patches when babel was still in the
CVS repository. Anyhow we would of course prefer to
It looks like we have a two options on how to adress this issue:
a) fix the whitespace errors before commiting the initial patch (which
might be an issue with the IP team)
b) fix the whitespace errors in a commit that comes right after the
initial commit. (which persists the whitespace errors in the
repositories history)
From our point of view, the two options are both feasible as neither
has a significant overhead.
In addition we are wondering if there are any guidelines (either for
eclipse code globally or specific for the babel project) on how to
treat whitespace (e.g. indention with tabs vs. spaces) that we should
adhere to when fixing the existing issues.
Anyway, please let us know your opinion and or preference regarding
this issue,
thank you,
best regards,
Stefan
