RE: [wtp-releng] Smoke Test Request for WTP 3.0.4 RC2

[Raghunathan Srinivasan <raghunathan.srinivasan@xxxxxxxxxx>]

Hi,

 

I would like to re-spin 3.0.4 to pick a change that was left out in the code we released yesterday. I have include the patch that reflects the change and this change should not affect the smoke tests of the other team. Please let me know if I can release the change.

-Raghu

### Eclipse Workspace Patch 1.0

#P org.eclipse.jst.pagedesigner

Index: src/org/eclipse/jst/pagedesigner/editors/HTMLEditor.java

===================================================================

RCS file: /cvsroot/webtools/org.eclipse.jsf/components/jsf/plugins/org.eclipse.jst.pagedesigner/src/org/eclipse/jst/pagedesigner/editors/HTMLEditor.java,v

retrieving revision 1.17.2.1

diff -u -r1.17.2.1 HTMLEditor.java

--- src/org/eclipse/jst/pagedesigner/editors/HTMLEditor.java           5 Feb 2009 00:12:54 -0000         1.17.2.1

+++ src/org/eclipse/jst/pagedesigner/editors/HTMLEditor.java        5 Feb 2009 18:40:44 -0000

@@ -934,12 +934,12 @@

                 if (element.getName().equals(

                         IJMTConstants.PROPERTY_PAGE_FACTORY))

                 {

-                    elementEditElement[j].getAttribute("factory"); //$NON-NLS-1$

+                    elementEditElement[j].getAttribute("class"); //$NON-NLS-1$

                     Object obj;

                     try

                     {

                         obj = elementEditElement[j]

-                                .createExecutableExtension("factory"); //$NON-NLS-1$

+                                .createExecutableExtension("class"); //$NON-NLS-1$

 

                         // TODO: we need a policy based solution here,

                         // but this will do for now

 

---

From: David M Williams [mailto:david_williams@xxxxxxxxxx]
Sent: Thursday, February 05, 2009 1:28 AM
To: wtp-releng@xxxxxxxxxxx
Subject: [wtp-releng] Smoke Test Request for WTP 3.0.4 RC2

 

Please smoke test the 3.0.4 M-build and update the smoketest page with your results by 3 PM EST Friday (at the latest).
Or let us know if that's not possible.

Build
http://build.eclipse.org/webtools/committers/wtp-R3.0-M/20090204230324/M-3.0.4-20090204230324/

Smoketest Results
http://wiki.eclipse.org/WTP_Smoke_Test_Results_R304_020509


There is actually another build spinning as I send out this notice, but the only change was some JSF committed fixes,
so all other teams can begin with this build ... if that next one is not ready yet by the time you read this.