Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [wtp-pmc] Stalled WS, javaee, and SSE gerrit requests for master branch: please review and merge!

On 12/05/2017 10:12 PM, Nick Boldt wrote:
These PRs are stalled with gerrit reviews passing them:

[webservices] [7 days old] https://git.eclipse.org/r/#/c/112472/ - add missing doc plugins to update site
[javaee] [5 days old] https://git.eclipse.org/r/#/c/112600/add upstream repos to root pom

Can they be merged?

These PRs for SSE are stalled after 7 days, with gerrit reviews showing some failing tests - the same failing tests we have in master already.

https://git.eclipse.org/r/#/c/112479/ - clean up site category.xml
https://git.eclipse.org/r/#/c/112519/ - move org.eclipse.wst.sse.unittests, org.eclipse.jst.jsp.core.tests and org.eclipse.jst.jsp.ui.tests to integration profile
https://git.eclipse.org/r/#/c/112521/ - add missing bundles to update site: org.eclipse.jst.jsp.core

Can these too be merged?

No:

- 112519 - is abandoned as it's replaced by https://git.eclipse.org/r/#/c/112570/ which is merged
- Two others cannot be merged as both are based over a change that is abandoned and thus cannot be rebased on top of master branch in Gerrit. (Manual rebase results into 3-way merge which succeeds, but still it's better to get these changes to be re-done by their author).

So, if these three changes are still thevalid ones, please rebase and submit their updated versions to Gerrit.

Thanks in advance,
Victor



Thanks,

Nick

--

Nick Boldt

Senior Software Engineer, RHCSA

Productization Lead :: JBoss Tools & Dev Studio

IM: @nickboldt / @nboldt / http://nick.divbyzero.com



_______________________________________________
wtp-pmc mailing list
wtp-pmc@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/wtp-pmc



Back to the top