Skip to main content
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [wtp-dev] gerrit review for JAXWS bugzilla
(Adding mailing lists for wider audience.)

I still think you want a plugin-level dep... but if you want a feature-level one too, then here's another PR:


Note that I'm using equivalent to allow 1.2.x, rather than perfect... which might in fact break if a different version of 1.2.0 appears in Orbit compared to the version used to build. (1.2.0.vyyyymmddsome-date != 1.2.0.vyyyymmddlater-date). Equivalent seems safer unless you know for sure that 1.2.1 is incompatible with 1.2.0.

If you like it, and PMC+2 it, you can merge it and I'll respin RC3 [1] for you. 

If you don't like it, and want to apply your own fix, I'll make sure that it's rebuilt and re-aggregated too. 

Just make sure you do whatever PMC approval process you feel is necessary in the BZ [2] so that the rest of the PMC don't complain/revert/quote wiki-scripture at you. :D


On Mon, Jun 4, 2018 at 3:18 PM, Keith Chong <kchong@xxxxxxxxxx> wrote:

Unfortunately, it's more of a dependency at runtime. In org.eclipse.jst.ws.axis.consumption.ui, there is a command that copies the saaj.jar from the lib folder of the 1.2 version of javax.xml.soap into the Web project. The 1.3 version does not have it.

The feature is not the place to fix this? The change should be (instead of using greaterOrEqual):

<import plugin="javax.xml.soap" version="1.2.0" match="perfect"/>

Not sure why the CXF plugin needs to be changed since this is Axis1 related.

Regards,
Keith Chong
WTP Web Services



Inactive hide details for Nick Boldt ---2018/06/04 03:02:04 PM---I've documented the JavaEE Perspective issue here: https://urlNick Boldt ---2018/06/04 03:02:04 PM---I've documented the JavaEE Perspective issue here: INVALID URI REMOVED

From: Nick Boldt <nboldt@xxxxxxxxxx>
To: Keith Chong <kchong@xxxxxxxxxx>
Cc: Elson Yuen <eyuen@xxxxxxxxxx>, Mat Booth <mat.booth@xxxxxxxxxx>, Shane Clarke <shane.clarke@xxxxxxxxxxx>
Date: 2018/06/04 03:02 PM


Subject: Re: gerrit review for JAXWS bugzilla



I've documented the JavaEE Perspective issue here:

https://wiki.eclipse.org/New_Help_for_Old_Friends_X (the old doc was empty so instead of creating an XI version, I just repurposed the X version. Now they align with the WTP version, in that 3.10 ==> 10 ==> X. 

----

Regarding the version of javax.xml.soap, I'd prefer if the dependency was expressed in a MANIFEST file so we know exactly which plugin requires it, and which version. 

Why is 1.2 required, and why 1.3 is not compatible? 

Note that while the WTP site contains javax.xml.soap 1.3.0.v201105210645, the Photon site contains javax.xml.soap 1.2.0.v201005080501 so both are available to be installed.

When I installed 20180531-0841_eclipse-jee-photon-RC2-linux.gtk.x86_64.tar.gz then installed into that all of WTP from the RC2 site [1], I got javax.xml.soap 1.2.0 installed.

[1]  http://download.eclipse.org/webtools/downloads/drops/R3.10.0/S-3.10.0.RC2-20180524070951/repository/

When I try to update to WTP 3.10.0.RC3 [2], or install from scratch using [2], I get  javax.xml.soap 1.3.0.v201105210645 installed.

[2] http://download.eclipse.org/webtools/downloads/drops/R3.10.0/S-3.10.0.RC3-20180601164520/repository/

So... here's a PR to restrict the version of javax.xml.soap needed in org.eclipse.jst.ws.jaxws.core:

https://git.eclipse.org/r/#/c/123947/




On Mon, Jun 4, 2018 at 2:25 PM, Keith Chong <kchong@xxxxxxxxxx> wrote:
    Yes, it should be added.

    I hit a regression with the Axis web services wizard. It fails with an NPE.

    I noticed we are now pulling in version 1.3.0 of javax.xml.soap. The original had a hard dependency on 1.2:

    <import plugin="javax.xml.soap" version="1.2.0" match="greaterOrEqual"/>

    Could we get this changed back to 1.2 in     webservices/webtools.webservices/ core/features/org.eclipse.wst.ws_core.feature/feature.xml

    Regards,
    Keith Chong
    WTP Web Services



    Inactive hide details for Nick Boldt ---2018/06/04 01:07:54 PM---No prob. Should this be added to a New Help For Old Friends paNick Boldt ---2018/06/04 01:07:54 PM---No prob. Should this be added to a New Help For Old Friends page? Seems not immediately intuitive.

    From:     Nick Boldt <nboldt@xxxxxxxxxx>
    To:     Keith Chong <kchong@xxxxxxxxxx>
    Cc:     Elson Yuen <eyuen@xxxxxxxxxx>, Mat Booth <mat.booth@xxxxxxxxxx>, Shane Clarke <shane.clarke@xxxxxxxxxxx>
    Date:     2018/06/04 01:07 PM


    Subject:     Re: gerrit review for JAXWS bugzilla




    No prob. Should this be added to a New Help For Old Friends page? Seems not immediately intuitive. 

    https://wiki.eclipse.org/New_Help_for_Old_Friends_X
    https://wiki.eclipse.org/New_Help_for_Old_Friends_XI

    On Mon, Jun 4, 2018 at 12:56 PM, Keith Chong <kchong@xxxxxxxxxx> wrote:
        Hey Nick, thanks. Still trying to catch up on the e-mails - That resolved it.

        Regards,
        Keith Chong
        WTP Web Services


        Inactive hide details for Nick Boldt ---2018/06/04 12:33:30 PM---This problem (or similar) was reported last week for the RC2 sNick Boldt ---2018/06/04 12:33:30 PM---This problem (or similar) was reported last week for the RC2 smoke test too, so it's hopefully not r

        From:         Nick Boldt <nboldt@xxxxxxxxxx>
        To:         Keith Chong <kchong@xxxxxxxxxx>
        Cc:         Mat Booth <mat.booth@xxxxxxxxxx>, Shane Clarke <shane.clarke@xxxxxxxxxxx>, Elson Yuen <eyuen@xxxxxxxxxx>
        Date:         2018/06/04 12:33 PM


        Subject:         Re: gerrit review for JAXWS bugzilla




        This problem (or similar) was reported last week for the RC2 smoke test too, so it's hopefully not related.

        From Ian Trimble:
        > I saw some related (I think) weirdness.
        > When I tried to open the “Java EE” perspective, it was initially not present. I had to select the “Show all” checkbox below the list (I’ve never even noticed this checkbox before, let alone selected it.) At this point, the “Java EE” perspective was shown in the list. I selected it and clicked “Open”, which caused a “Confirm Enablement” dialog to display. I confirmed enablement of “Java EE Development”, and from there was able to complete my smoke test without further issue.

        -- https://dev.eclipse.org/mhonarc/lists/wtp-releng/msg10982.html

        Cheers,

        Nick

        On Mon, Jun 4, 2018 at 12:24 PM, Keith Chong <kchong@xxxxxxxxxx> wrote:
                In the RC3 Smoke Test driver, the WSDL Editor doesn't appear. Looks like the most, if not all, core and JAX-WS web services plugins are only in the Starting state, and not loaded. For example:

                org.eclipse.wst.ws (1.1.400.v201805181041) "Web Services" [Starting]
                org.eclipse.wst.wsdl (1.2.500.v201805181041) "WSDL Model" [Starting]
                org.eclipse.wst.wsdl.ui (1.2.801.v201805181041) "WSDL UI" [Starting]

                Not sure if it is because of this change but if it is, is it too late to back it out?                 https://bugs.eclipse.org/bugs/show_bug.cgi?id=265772

                Regards,
                Keith Chong
                WTP Web Services


                Inactive hide details for Keith Chong---2018/06/04 11:49:25 AM---I added a comment to https://bugs.eclipse.org/bugs/show_bug.cgKeith Chong---2018/06/04 11:49:25 AM---I added a comment to https://bugs.eclipse.org/bugs/show_bug.cgi?id=265772Mat, your change to org.ecl

                From:                 Keith Chong/Toronto/IBM
                To:                 Mat Booth <mat.booth@xxxxxxxxxx>
                Cc:                 Nick Boldt <nboldt@xxxxxxxxxx>, Shane Clarke <shane.clarke@xxxxxxxxxxx>, Elson Yuen/Toronto/IBM@IBMCA
                Date:                 2018/06/04 11:49 AM
                Subject:                 Re: gerrit review for JAXWS bugzilla


                I added a comment to

                https://bugs.eclipse.org/bugs/show_bug.cgi?id=265772

                Mat, your change to org.eclipse.wst.wsdl (the WTP EMF-based WSDL model) only implements the newer versions of the interfaces? It looks like you are just implementing the new methods. So I think adopters of the WTP Photon WSDL model _should_ be ok.

                The other concern is that if WTP only 'ships' 1.6.2, then are we forcing adopters to move their 1.5.1-based plugins to 1.6.2?

                FWIW, I know that some of the new changes in 1.6.x include a new package and classes that supports SOAP 1.2 and there is a new WSDLElement interface that makes your code cleaner (at a more abstract level). So, if you don't use these new features, technically, your 1.5.2-based plugin will still compile cleanly against 1.6.2.


                Regards,
                Keith Chong
                WTP Web Services




                Inactive hide details for Mat Booth ---2018/06/04 11:23:54 AM---Aha, thanks. I suppose we'll need to move the Fedora RPM away fMat Booth ---2018/06/04 11:23:54 AM---Aha, thanks. I suppose we'll need to move the Fedora RPM away from the monolithic build for next rel

                From:                 Mat Booth <mat.booth@xxxxxxxxxx>
                To:                 Nick Boldt <nboldt@xxxxxxxxxx>
                Cc:                 Mat Booth <mat.booth@xxxxxxxxxx>, Shane Clarke <shane.clarke@xxxxxxxxxxx>, Keith Chong <kchong@xxxxxxxxxx>
                Date:                 2018/06/04 11:23 AM
                Subject:                 Re: gerrit review for JAXWS bugzilla




                Aha, thanks. I suppose we'll need to move the Fedora RPM away from the monolithic build for next release then :-)



                On 4 June 2018 at 16:17, Nick Boldt <nboldt@xxxxxxxxxx> wrote:




        --
        Nick Boldt
        Principal Software Engineer, RHCSA
        Productization Lead :: JBoss Tools & Dev Studio
        IM: @nickboldt / @nboldt /         http://nick.divbyzero.com

    TRIED. TESTED. TRUSTED.




    --
    Nick Boldt
    Principal Software Engineer, RHCSA
    Productization Lead :: JBoss Tools & Dev Studio
    IM: @nickboldt / @nboldt /     http://nick.divbyzero.com


TRIED. TESTED. TRUSTED.




--
Nick Boldt
Principal Software Engineer, RHCSA
Productization Lead :: JBoss Tools & Dev Studio
IM: @nickboldt / @nboldt / http://nick.divbyzero.com

TRIED. TESTED. TRUSTED.
@ @redhatnews      Red Hat


“The Only Thing That Is Constant Is Change” - Heraclitus





--

Nick Boldt

Principal Software Engineer, RHCSA

Productization Lead :: JBoss Tools & Dev Studio

IM: @nickboldt / @nboldt / http://nick.divbyzero.com



“The Only Thing That Is Constant Is Change” - Heraclitus

Back to the top