Skip to main content
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
[wtp-dev] URGENT - Please review TODAY (was Re: gerrit review for JAXWS bugzilla)
Adding PMC to cc: so they're aware of the need for a +1.

I've added the usual suspects to the first BZ - the second already has Elson's +1 so I assume we're good there as generally everyone else just ignores these things. :)

https://bugs.eclipse.org/bugs/show_bug.cgi?id=534747
https://bugs.eclipse.org/bugs/show_bug.cgi?id=265772

As TODAY is the usual day for spinning up a build for smoke test (so people have Fri & Mon to review prior to the Tuesday deadline), this is somewhat urgent. 



On Thu, May 31, 2018 at 2:47 AM, Shane Clarke <shane.clarke@xxxxxxxxxxx> wrote:
Hi Guys,

Sorry for being late with getting to this.

For https://git.eclipse.org/r/#/c/122761/ if we can get the PMC votes for RC3 i'll get it in.

And for https://git.eclipse.org/r/#/c/122932/  i think Keith should sign off on it if possible.

Thanks,
Shane


From: Nick Boldt <nboldt@xxxxxxxxxx>
Sent: Wednesday 30 May 2018 14:18
To: Mat Booth
Cc: Shane Clarke; Keith Chong
Subject: Re: gerrit review for JAXWS bugzilla
 
I've merged the fix for parent pom and rebuilt it.

https://hudson.eclipse.org/webtools/job/webtools-webservices-gerrit_master/ will trigger once the current wtp common build is done (it's rebuilding because of the parent pom change).

On Wed, May 30, 2018 at 8:19 AM, Mat Booth <mat.booth@xxxxxxxxxx> wrote:
Another update -- My Orbit fix is now available in an I-build, so I submitted the following change for the wtp-parent to update its orbit repo reference: https://git.eclipse.org/r/#/c/123635/

If that is merged, then jenkins should be able to do a successful build of this change: https://git.eclipse.org/r/#/c/122932/


On 23 May 2018 at 10:45, Mat Booth <mat.booth@xxxxxxxxxx> wrote:
Regarding this second change, my fix for Orbit was merged, and the new wsil4j bundle is available from the latest Orbit nightly repo: http://download.eclipse.org/tools/orbit/N-builds/N20180522205425/


On 19 May 2018 at 01:18, Nick Boldt <nboldt@xxxxxxxxxx> wrote:
There's also a second gerrit for review here [1] but that requires a fix in Orbit [2] first.


So... I guess that will require the post-RC1 PMC approval process. 

On Fri, May 18, 2018 at 9:06 AM, Nick Boldt <nboldt@xxxxxxxxxx> wrote:
Please have a look and if you approve, merge this:


> Bug 534747 - Use import-package for deps that can be supplied by the jre

This makes WTP more compatible with other platforms (like linux) where Eclipse can be installed via rpm.

Hopefully the Jenkins on which the gerrit is building won't crap out like the ones the other day. Seems ci.eclipse.org is a bit overloaded these days. Must be RC season. :)

Nick

--

Nick Boldt

Principal Software Engineer, RHCSA

Productization Lead :: JBoss Tools & Dev Studio

IM: @nickboldt / @nboldt / http://nick.divbyzero.com


“The Only Thing That Is Constant Is Change” - Heraclitus



--

Nick Boldt

Principal Software Engineer, RHCSA

Productization Lead :: JBoss Tools & Dev Studio

IM: @nickboldt / @nboldt / http://nick.divbyzero.com


“The Only Thing That Is Constant Is Change” - Heraclitus





--

Nick Boldt

Principal Software Engineer, RHCSA

Productization Lead :: JBoss Tools & Dev Studio

IM: @nickboldt / @nboldt / http://nick.divbyzero.com


“The Only Thing That Is Constant Is Change” - Heraclitus



--

Nick Boldt

Principal Software Engineer, RHCSA

Productization Lead :: JBoss Tools & Dev Studio

IM: @nickboldt / @nboldt / http://nick.divbyzero.com



“The Only Thing That Is Constant Is Change” - Heraclitus

Back to the top