Skip to main content
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [wtp-dev] JDK 10 support in WTP 3.9.4 (Oxygen.3a) and 3.10.0.M7 (was: Declaring Build for wtp-R3.9.3-M: S-3.9.3RC4-20180302093744)
Nick,
 
     For Java Facet support, adding in the facet is enough- If you look, the current org.eclipse.jst.common.project.facet.core has a BREE of 1.5, yet it supports everything through Java 9.
     As a rule overall, we don't need to modify the toolchains until we have a bundle with a BREE of that level, and we should not have a BREE of any Java level above the minimum Java supported by that release's platform.  (For Photon, the minimum Java version is Java 8 - see https://www.eclipse.org/projects/project-plan.php?planurl=http://www.eclipse.org/eclipse/development/plans/eclipse_project_plan_4_8.xml )  Any exception to this needs to be approved by the PMC.
 
FWIW,
 
- Carl Anderson
 
----- Original message -----
From: Nick Boldt <nboldt@xxxxxxxxxx>
Sent by: wtp-dev-bounces@xxxxxxxxxxx
To: "General discussion of project-wide or architectural issues." <wtp-dev@xxxxxxxxxxx>
Cc:
Subject: [wtp-dev] JDK 10 support in WTP 3.9.4 (Oxygen.3a) and 3.10.0.M7 (was: Declaring Build for wtp-R3.9.3-M: S-3.9.3RC4-20180302093744)
Date: Wed, Mar 14, 2018 1:24 PM
 
I've opened https://bugs.eclipse.org/bugs/show_bug.cgi?id=532353 to track adding the Java 10 facet in R3_9 and master branches.
 
Do we need to get JDK 10 installed on the JIPP and added to the toolchains.xml file? Does this change require bumping a BREE up to minimum version = JDK 10?
 
Forgive the dumb questions, but this stuff's outside my sphere of expertise. 
 
Cheers,
 
Nick
 
On Wed, Mar 7, 2018 at 4:46 PM, Jesper Steen Møller <jesper@xxxxxxxxxxxxx> wrote:

> On 7 Mar 2018, at 20.37, Jesper Steen Møller <jesper@xxxxxxxxxxxxx> wrote:
>
>
>> On 7 Mar 2018, at 17.40, Nick Boldt <nboldt@xxxxxxxxxx> wrote:
>> [...]
>> Has anyone started work on JDK 10 support in WTP? Just curious in which projects I should expect to see changes.
>>
>
> I really doubt there's anything to do for WTP for JDK 10, unless there is a classfile version check somewhere in there? The only language issue is the 'var' reserved word. I guess we could stop people using the new servlet wizard from using 'var' as a type name, but that's about it.
>

^^^^ Sorry - that was nonsense, as per Carl's analysis...

What I should have written is that there's only a smaller AST change, addition of a (read-only) property: org.eclipse.jdt.core.dom.SimpleType.isVar()

From what little I know about JEM, it should not be affected by the JDK 10 change.

-Jesper

_______________________________________________
wtp-dev mailing list
wtp-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/wtp-dev
 
 
--

Nick Boldt

Senior Software Engineer, RHCSA

Productization Lead :: JBoss Tools & Dev Studio

IM: @nickboldt / @nboldt / http://nick.divbyzero.com

 
 
“The Only Thing That Is Constant Is Change” - Heraclitus
_______________________________________________
wtp-dev mailing list
wtp-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://urldefense.proofpoint.com/v2/url?u=https-3A__dev.eclipse.org_mailman_listinfo_wtp-2Ddev&d=DwICAg&c=jf_iaSHvJObTbx-siA1ZOg&r=6JCYBixIS0G6Rj43h5xZSA&m=jrk70I3nSPt27SgyqmZxQXgiPYBEUQepiQNwiQ9OcYM&s=bafwZ8woB0NSC8i_c2X3gcpbZ60D-kJ9P6auvCLG5Jg&e=
 

Back to the top