Skip to main content
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [wtp-dev] Broken SSE builds due to compilation error, but only in Hudson (can't reproduce locally)
John,

Glad you're on board with updating to 1.8.

Here's what *I* would do, because I tend to prefer commandline tools over GUI ones.

1. I would start with piping all the manifest files through sed...

   for m in $(find . -name MANIFEST.MF); do sed -i -e "s#J2SE-1\..#JavaSE-1.8#" -e "s#JavaSE-1\..#JavaSE-1.8#" ${m}; done

2. Run a build to see what breaks with the updated manifests from 1.4, 1.5, 1.6 -> 1.8.

(If you don't like sed, there's prolly a way to do the whole thing in Eclipse, but that'll likely have to be done one plugin at a time.)

3. Then fix all the compilation complaints in Eclipse. 

4. You'll probably also want to bump all your plugins/features from x.y.z to x.(y+1).z to avoid breaking old consumers.

The easiest way for that is to run this:

mvn -Dtycho.mode=maven org.eclipse.tycho:tycho-versions-plugin:1.0.0:set-version -DnewVersion=5.6.7-SNAPSHOT

But bear in mind that it expects ALL plugins/features to be the same version, and if your project doesn't roll that way, it won't bump everything in the reactor in one fell swoop, so you'll have to run it in each and every plugin folder. Or just edit your MANIFEST.MF and pom.xml files by hand.

Nick



On Mon, Dec 18, 2017 at 12:50 PM, John J Collier <John.J.Collier@xxxxxxx> wrote:
I agree that we should try and bump the BREE wherever possible. JEE Tools for example seems to still be on a BREE of J2SE-1.5, if we could get that up to 1.8, that would be great.

Nick, what would have to be done to bump up JEE Tools to 1.8?


Regards,

John Collier
Software Developer, WDT/IBM Cloud
Email: John.J.Collier@xxxxxxx
Phone: (905)-413-3389



From:        Nick Boldt <nboldt@xxxxxxxxxx>
To:        Nitin Dahyabhai <nitin.dahyabhai@xxxxxxxxx>
Cc:        Keith Chong <kchong@xxxxxxxxxx>, Victor Rubezhny <vrubezhn@xxxxxxxxxx>, "General discussion of project-wide or architectural issues." <wtp-dev@xxxxxxxxxxx>
Date:        2017/12/18 10:57 AM
Subject:        Re: [wtp-dev] Broken SSE builds due to compilation error, but only in Hudson (can't reproduce locally)
Sent by:        wtp-dev-bounces@xxxxxxxxxxx



*wild cheering for dropping support for BREE = J2SE-1.4*

*waves Team Nitin flag* 

If you're keen to break some more eggs, please have a look at https://bugs.eclipse.org/bugs/show_bug.cgi?id=528800re: updating toolchains.xml to the latest JDKs, and maybe removing support for obsolete BREEs like JDK 1.4 - 1.7.

Just a thought!

Nick



On Mon, Dec 18, 2017 at 10:45 AM, Nitin Dahyabhai <nitin.dahyabhai@xxxxxxxxx> wrote:
I intend to bump up the BREE of both SSE core and UI to 1.8 in the master branch to get us past this once and for all. With the platform dependencies already there, as long as I can keep the code compliance itself where it is (it's more a pragmatic choice than a dogmatic one) I don't see much cause not to.

-Nitin

On Dec 18, 2017, at 10:37 AM, Nick Boldt <nboldt@xxxxxxxxxx> wrote:

I've been seeing this for about a week now:

[ERROR] Failed to execute goal org.eclipse.tycho:tycho-compiler-plugin:1.0.0:compile (default-compile) on project org.eclipse.wst.sse.ui: Compilation failure: Compilation failure:
[ERROR] /jobs/genie.webtools/webtools-sourceediting_R3_10/workspace/core/bundles/org.eclipse.wst.sse.ui/src/org/eclipse/wst/sse/ui/internal/StructuredTextAnnotationHover.java:[43]
[ERROR] HTMLPrinter.addPageProlog(buffer);
[ERROR] ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[ERROR] The type java.lang.StringBuilder cannot be resolved. It is indirectly referenced from required .class files

Affected jobs:
* https://hudson.eclipse.org/webtools/view/webtools_R3_10/job/webtools-sourceediting_R3_10/
* https://hudson.eclipse.org/webtools/view/webtools_R3_10/job/WTP-R3_10_Integration/

Anyone have time to investigate why this is failing, and offer a fix? I tried to have Hudson ignore the workspace settings files, which worked in the gerrit job but didn't fix the problem in the other jobs. 

Related bug: https://bugs.eclipse.org/bugs/show_bug.cgi?id=528778

BTW, are the SSE committers seeing the mail sent to wtp-releng@xxxxxxxxxxx?

Thanks in advance,

--
Nick Boldt
Senior Software Engineer, RHCSA
Productization Lead :: JBoss Tools & Dev Studio
IM: @nickboldt / @nboldt / http://nick.divbyzero.com

TRIED. TESTED. TRUSTED.

@ @redhatnews     Red Hat



--
Nick Boldt
Senior Software Engineer, RHCSA
Productization Lead :: JBoss Tools & Dev Studio
IM: @nickboldt / @nboldt / http://nick.divbyzero.com

TRIED. TESTED. TRUSTED.

@ @redhatnews     Red Hat_______________________________________________
wtp-dev mailing list
wtp-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://urldefense.proofpoint.com/v2/url?u=https-3A__dev.eclipse.org_mailman_listinfo_wtp-2Ddev&d=DwICAg&c=jf_iaSHvJObTbx-siA1ZOg&r=6q9DBEiC7mYUpxGNnkdhHBpN_7m_NuKsWnDlkmpsTd4&m=yleicvggdbs8IhYGQg0-YbWEXXoA1kzbeg042TBSZhU&s=gyQsP-x7tLKC2xqGxHwQL-cCF72UNnGDskXnZNDIy-0&e=



_______________________________________________
wtp-dev mailing list
wtp-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/wtp-dev



--

Nick Boldt

Senior Software Engineer, RHCSA

Productization Lead :: JBoss Tools & Dev Studio

IM: @nickboldt / @nboldt / http://nick.divbyzero.com

Back to the top