Skip to main content
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [wtp-dev] JSDT Sync call minutes [20160112]
Hi everybody,

Here my comments:

1) Gulp and Grunt work

Is it possible to debug grunt/gulp tasks? I would like to support it for https://github.com/angelozerr/jsbuild-eclipse
 
2) [Bug 443097] Ignore undefined HTML attributes, elements validation with extension point

I must find time to try to implement custom validator for AngularJS Eclipse. I think it's a good use case because angular has some complex cases.

3) Bug 482841 - JSDT to utilize org.eclipse.wst.validation.validatorV2 extension point

If you need use cases you can try it with tern.java which uses WTP Validator to validate with JSHint, ESLInt etc https://github.com/angelozerr/tern.java/wiki/Tern-Linter

You must comment thoses line https://github.com/angelozerr/tern.java/blob/master/eclipse/jsdt/tern.eclipse.ide.jsdt.ui/src/tern/eclipse/ide/jsdt/internal/ui/JavaEditorTracker.java#L178
which is my hack to plug JSDT JavaEditor with WTP validator because JSDT is not a IStrcuturedModel. 

IMHO, I think it should be very good to benefit with SSE validator for any editor even if the editor doesn't maintain a IStructuredModel.

4) JSON Editor

At first do you like the IJSONModel API with IJSONPair etc?

I think it should be very good to integrate JUnit tests https://github.com/angelozerr/eclipse-wtp-json/tree/master/core/org.eclipse.wst.json.core.tests that I have not included in the gerrit patch (Victor told me to remove it).

I think the main bugs you will find it's because sync of IJSONModel and editor is not robust. IMHO I think you should improve that (but it's a very hard task).

I had started to create a tests for this sync at https://github.com/angelozerr/eclipse-wtp-json/blob/master/core/org.eclipse.wst.json.core.tests/src/org/eclipse/wst/json/core/document/JSONObjectDocumentChangesTest.java

In other words I think you should add new tests and fix problem with sync.

Regard's Angelo





2016-01-12 20:55 GMT+01:00 Gorkem Ercan <gorkem.ercan@xxxxxxxxx>:

Hi,
The meeting minutes from today's call is up at https://wiki.eclipse.org/JSDT/Confcalls/Minutes_20160112

Thanks everyone for attending
--
Gorkem
_______________________________________________
wtp-dev mailing list
wtp-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/wtp-dev

Back to the top