| [wtp-dev] New in JSDT: Hudson votes on Gerrit contributions and Sonar |
|
Hi all, This is the time when we can start seeing profit from the previous refactorings on JSDT. Hudson now votes on patches submitted to Gerrit This job https://bugs.eclipse.org/bugs/show_bug.cgi?id=425792 now automatically runs a build+tests for each patch submitted to Gerrit and will vote +1 or -1 depending on whether the patch causes a regression or not. For example, the job notified the committers that contribution https://git.eclipse.org/r/#/c/20762/ doesn't show any noticeable regression based on the JUnit tests, so it makes less things to check for committers before merging a patch, and generally less time to wait for contributors before noticing they did something wrong. I would highly recommend everyone (including project committers) to use Gerrit now, as it is a good way to avoid obvious regressions and keep most bugs out of master branch. Documentation on how to use Gerrit from a code contributor and a reviewer point of view was updated: https://wiki.eclipse.org/JSDT/Development#Gerrit_Reviews . The most important part is probably to set up mail notifications to make sure patches don't get ignored. Sonar reports about static analysis and tests This job https://hudson.eclipse.org/webtools/job/jsdt-sonar is planned to run weekly and will run build + tests + Sonar analysis. The output of Sonar analysis (relying on FindBugs, PMD, Checkstyle and Sonar itself) is available at https://dev.eclipse.org/sonar/dashboard/index/org.eclipse.webtools.jsdt:jsdt-parent . They already show some interesting hotspots where code can be improved to avoid bugs. I would recommend planning some Sonar cleaning sessions before each milestone release, at least to make sure no obvious issue was introduced. For those who are interested in avoiding most of those warnings, then I advise using FindBugs in the IDE. It will spot most of the bad practice you see in Sonar directly in your IDE, as you type. If you go for a warning hunt, it's definitely your best friends. I'll probably provide some patch for some of the most important issues Sonar has found within the next days. Anyone is free to join this effort. I believe that these 2 tools will be helpful to make JSDT better and better, and an easy place for contributors to provide code and get their effort noticed and honored (which is not that easy with Bugzilla). Cheers, |