Re: [wtp-dev] Formatter vs Indenter in JSDT

[Simon Kaegi <Simon_Kaegi@xxxxxxxxxx>]

Actually, this forum might be an even better place for these sorts of questions -- http://www.eclipse.org/forums/eclipse.webtools
..but still log a bug.
-Simon

Simon Kaegi---08/17/2011 06:16:53 PM---Hi Bashir, Sorry I missed this until right now - our infrastructure changed and I hadn't switched fr

From:	Simon Kaegi/Ottawa/IBM
To:	"General discussion of project-wide or architectural issues." <wtp-dev@xxxxxxxxxxx>, Bashir Sadjad <bashir@xxxxxxxxxx>
Date:	08/17/2011 06:16 PM
Subject:	Re: [wtp-dev] Formatter vs Indenter in JSDT

---

Hi Bashir,

Sorry I missed this until right now - our infrastructure changed and I hadn't switched from scanning the newsgroup to the mailing list. I think this dev list is a fine place to ask these sorts of things.
With that being said if you want to get our attention and think you may have found a problem (and in this case I think you have as formatter and indenter should be consistent) I'd suggest logging a bug -- https://bugs.eclipse.org/bugs/enter_bug.cgi?product=JSDT&component=General 

-Simon

Bashir Sadjad ---08/17/2011 12:20:02 PM---Ping! Is this the right place to ask JSDT related dev. questions?

From:	Bashir Sadjad <bashir@xxxxxxxxxx>
To:	wtp-dev@xxxxxxxxxxx
Date:	08/17/2011 12:20 PM
Subject:	Re: [wtp-dev] Formatter vs Indenter in JSDT
Sent by:	wtp-dev-bounces@xxxxxxxxxxx

---

Ping!

Is this the right place to ask JSDT related dev. questions?

-B

On Wed, Aug 10, 2011 at 3:48 PM, Bashir Sadjad <bashir@xxxxxxxxxx> wrote:

Hi,

This is a question related to JSDT indenter which I hope this is the right place to ask.

The basic problem is that indenter and formatter are not consistent. For example with some formatter preferences tweaks, I can get 4 spaces before '[' in:

var t =
    [
      'a', 'b'
    ];

which is what I want. However if I select this segment and just run indenter it changes the indent to 2 spaces. I cannot find any JSDT settings that changes this indenter behavior. Debugging the code a little bit it seems that org.eclipse.wst.jsdt.internal.ui.text.JavaIndenter has a CorePrefs internal class with a prefAssignmentIndent field that determines this indent. However this indent size is simply set to prefBlockIndent() which is (eventually) hard-coded 1. So

(i) Is this behavior intended?
(ii) If not is there any plan/open-bug to fix it? If yes, why (i.e., shouldn't formatter and indenter be consistent)?

Thanks

-B 
Bashir S. Sadjad
Google Waterloo, Canada
http://sadjad.info

-- 
Bashir S. Sadjad
Google Waterloo, Canada_______________________________________________
wtp-dev mailing list
wtp-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/wtp-dev