Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [wtp-dev] Breaking changes to IServer

> but I rather release the changes now than having to file for an exception in M7 and give the PMC more work in M7

I'm not saying if releasing this potentially breaking change the last week of M6 is a good or bad thing to do ... that's mostly between your project committers and adopters,
but I would like to take your note as an opportunity to emphasize that as a general rule it is never the right thing to "cram in changes" just to avoid filing for an exception. The PMC doesn't mind the extra work :) because we love stability so much :) (And, its not even all that much work). I just like to remind everone not to be afraid of filing for exceptions, they are just a means to make things more orderly.

So, by all means, do what you think best for this case (it does sound important) and thank you for the wide-spread notice here to wtp-dev.

From: Angel Vera <arvera@xxxxxxxxxx>
To: "General discussion of project-wide or architectural issues." <wtp-dev@xxxxxxxxxxx>
Date: 03/08/2010 11:48 AM
Subject: [wtp-dev] Breaking changes to IServer
Sent by: wtp-dev-bounces@xxxxxxxxxxx

My apologies for releasing this changes in the last week of M6, but I rather release the changes now than having to file for an exception in M7 and given the PMC more work in M7.

If you are implementing IServer, continue reading...

Today I have released changes to IServer that will break you. The changes deprecate the old .canControlModule(IModule[] module, IProgressMonitor monitor) and now introduce .canRestartModule(...) and .canPublishModule(...) to replace the function of the old one.

The changes should be pretty safe as they introduce new APIs and the old one is still kept. Nevertheless, the changes will break you if you implement org.eclipse.wst.server.core.IServer, which it is recommended to not be implemented. This changes have also gone into related classes such as:
# org.eclipse.wst.server.core.internal.Server
# org.eclipse.wst.server.core.model.ServerBehaviourDelegate

The code changes come as part of the discussion in bug# 293742, if you have any comments please use that bug to provide them.


Best Regards,
-- --
Mr. Angel Vera
Server Tools Developer
E-Mail: arvera@xxxxxxxxxx
Tel: 905-413-5919
Those who think that something is impossible,
should not interfere with those who are willing to do it. - Angel Vera
wtp-dev mailing list

Back to the top