Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [wtp-dev] IDataModel framework changes coming.


Yes, we can revisit this in 2.0 and add back if necessary.

Thank you,

Jason A. Sholl
jsholl@xxxxxxxxxx
919-543-0011 (t/l 441-0011)



Peter Moogk <pmoogk@xxxxxxxxxx>
Sent by: wtp-dev-bounces@xxxxxxxxxxx

03/28/2006 05:06 PM

Please respond to
"General discussion of project-wide or architectural issues." <wtp-dev@xxxxxxxxxxx>

To
"General discussion of project-wide or architectural issues." <wtp-dev@xxxxxxxxxxx>
cc
Subject
Re: [wtp-dev] IDataModel framework changes coming.






Hi Jason,

    I'm fine with the removal of the getPreOperations and getPostOperations for WTP 1.5.  However, I just wanted some clarification about the getDataModelIDs method.  Our Web services team doesn't have a requirement for this method in WTP 1.5, but we will definitely have a requirement for it in WTP 2.0.  Therefore, is the plan to remove it for 1.5 and then add it back in again for WTP 2.0 or should it just be left in the WTP 1.5 api.  Thanks.



Peter Moogk
Rational Web Services Development
IBM Canada Ltd.
pmoogk@xxxxxxxxxx
D3-353/ENX/8200/MKM
(905) 413-3458


Jason A Sholl <jsholl@xxxxxxxxxx>
Sent by: wtp-dev-bounces@xxxxxxxxxxx

03/28/2006 04:37 PM

Please respond to
"General discussion of project-wide or architectural issues."

To
wtp-dev@xxxxxxxxxxx
cc
Subject
[wtp-dev] IDataModel framework changes coming.








If you are not using the IDataModel framework, then there is no need to continue reading this note.


In order to fix bugs https://bugs.eclipse.org/bugs/show_bug.cgi?id=125338 and https://bugs.eclipse.org/bugs/show_bug.cgi?id=118853, some api changes are necessary.  Though these changes are potentially breaking, I don't believe there was any usage outside the internal classes I have already cleaned up.  If there are no objections, I would like to put these changes in this week's integration build.


The following methods will be removed from the public API, because they no longer make sense:


org.eclipse.wst.common.frameworks.datamodel.AbstractDataModelOperation.getDataModelIDs()

org.eclipse.wst.common.frameworks.datamodel.AbstractDataModelOperation.getPreOperations()

org.eclipse.wst.common.frameworks.datamodel.AbstractDataModelOperation.getPostOperations()


org.eclipse.wst.common.frameworks.datamodel.IDataModelOperation.getDataModelIDs()

org.eclipse.wst.common.frameworks.datamodel.IDataModelOperation.getPreOperations()

org.eclipse.wst.common.frameworks.datamodel.IDataModelOperation.getPostOperations()


Substantial changes are necessary in various internal classes which include the removal of the following classes:


org.eclipse.wst.common.frameworks.internal.DataModelManager

org.eclipse.wst.common.frameworks.internal.OperationListener

org.eclipse.wst.common.frameworks.internal.OperationManager


org.eclipse.wst.common.frameworks.internal.datamodel.ExtendableOperationImpl


I have cleaned up all compile and runtime errors in the following plugins:


org.eclipse.wst.common.frameworks

org.eclipse.wst.common.frameworks.ui

org.eclipse.wst.common.modulecore

org.eclipse.wst.common.tests

org.eclipse.wst.common.tests.ui

org.eclipse.wst.web.ui


I did not find any references to any of the deleted classes or methods anywhere in WTP.  Lastly, I ran the api tool and am following up with the owners to determine whether they are legitimate concerns.  If anyone has concerns about these changes please let me know.


Thank you,

Jason A. Sholl
jsholl@xxxxxxxxxx
919-543-0011 (t/l 441-0011)
_______________________________________________
wtp-dev mailing list
wtp-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/wtp-dev

_______________________________________________
wtp-dev mailing list
wtp-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/wtp-dev


Back to the top