[
Date Prev][
Date Next][
Thread Prev][
Thread Next][
Date Index][
Thread Index]
[
List Home]
|
Re: [websocket-dev] [External] : Re: Removing restrictions on direct commits
|
All,
Now I have admin access it appears that if PRs are required then so are
reviews. We can't require PRs without the review. Therefore I am going
to remove the PR requirement.
The social requirement that substantive changes must be via PR and must
allow time for community review remains.
I'll try and make all my changes via PR but a few trivial fixes may end
up going directly to master.
Mark
On 04/11/2021 23:18, Ed Bratt wrote:
When reviewing changes further down the road, I find it easier to review
via PRs. I understand you can see the direct commits as well, but in my
perspective, these are harder to follow and unwind.
My preference -- and this is mostly as a reader -- is that projects
adopt a convention to use PRs, even for small changes -- even if the
submitter is just going to turn right around and hit the merge button.
My opinion, that's all.
-- Ed
On 11/4/2021 1:48 PM, Mark Thomas wrote:
As a first step, I have opened an issue to make the project leads
admins - as we should according to the Eclipse Handbook. With admin
karma, we should then be able to make changes to the review requirements.
Mark
On 02/11/2021 16:29, Mark Thomas wrote:
All,
In approx 24 hours time I intend to request that the branch
restrictions that prevent committers committing directly to the
master branch and those that require every PR to be reviewed before
merge are removed.
My reasoning is as follows:
- I have seen the benefits of these restrictions not being present in EL
- I'm expecting a number of non-substantive changes will be required to
successfully complete the release process and PR + review for all of
them will significantly slow us down
- Committers are perfectly capable of determining which changes need a
PR and review and which can be made directly - and if they get it
wrong changes can easily be reverted
I was intending to propose this change after the Jakarta 10 release
but on reflection, I think the sooner, the better.
Thoughts? Comments? Objections?
Mark
_______________________________________________
websocket-dev mailing list
websocket-dev@xxxxxxxxxxx
To unsubscribe from this list, visit
https://urldefense.com/v3/__https://www.eclipse.org/mailman/listinfo/websocket-dev__;!!ACWV5N9M2RV99hQ!ZXaPJ_2lrxntT4crrTbge_DgyBpJUYhh2hOFgetAtSlIXV4Ra_qRKksqY9T8pi0$
_______________________________________________
websocket-dev mailing list
websocket-dev@xxxxxxxxxxx
To unsubscribe from this list, visit
https://urldefense.com/v3/__https://www.eclipse.org/mailman/listinfo/websocket-dev__;!!ACWV5N9M2RV99hQ!ZXaPJ_2lrxntT4crrTbge_DgyBpJUYhh2hOFgetAtSlIXV4Ra_qRKksqY9T8pi0$
