Skip to main content
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [websocket-dev] Release review for WebSocket API 1.0.2
I opened PR https://github.com/eclipse-ee4j/websocket-api/pull/283 to fix the LICENSE / NOTICE file issues

And PR https://github.com/eclipse-ee4j/websocket-api/pull/284 to address the META-INF/MANIFEST.MF issue.

Once they are approved, I can merge them to master (there will likely be conflicts to resolve between them)

I'll file a new PR after the above 2 merge resolution to merge both of those to the new EE4J_8 branch

On Thu, Nov 8, 2018 at 2:19 PM Mark Thomas <markt@xxxxxxxxxx> wrote:
On 08/11/2018 17:11, Joakim Erdfelt wrote:
> The deployed (to staging) artifacts are version 1.1.1 (not 1.0.2)

Sorry. Concentration lapse. I was looking at the doc I am using to track
progress and I think I read the version from the wrong line.

> The jakarta.websocket-api.1.1.1.jar -
>
>   * is missing LICENSE and NOTICE files in the META-INF, need to fix this.
>   * META-INF/MANIFEST.MF looks good.

OK. Any idea how to fix this? I can probably find some time to look at
this fairly soon but some hints on where to look - or better still a PR
;) - would be very helpful.

> The jakarta.websocket-client-api-1.1.1.jar
>
>   * is missing LICENSE and NOTICE files in the META-INF, need to fix this.
>   * META-INF/MANIFEST.MF is essentially empty, need to fix this.
>
> Manifest-Version: 1.0
> Archiver-Version: Plexus Archiver
> Built-By: default
> Created-By: Apache Maven 3.5.4
> Build-Jdk: 1.8.0_181

Same as above.

Thanks for checking.

Mark


>
>
> On Thu, Nov 8, 2018 at 8:24 AM Mark Thomas <markt@xxxxxxxxxx
> <mailto:markt@xxxxxxxxxx>> wrote:
>
>     Hi all,
>
>     The 1.0.2 artefacts are now available in the staging repo:
>     https://oss.sonatype.org/content/groups/staging/jakarta/websocket/
>
>     I plan to start the release review for 1.0.2 early next week. Please
>     speak up if there are any objections.
>
>     Mark
>     _______________________________________________
>     websocket-dev mailing list
>     websocket-dev@xxxxxxxxxxx <mailto:websocket-dev@xxxxxxxxxxx>
>     To change your delivery options, retrieve your password, or
>     unsubscribe from this list, visit
>     https://www.eclipse.org/mailman/listinfo/websocket-dev
>
>
>
> _______________________________________________
> websocket-dev mailing list
> websocket-dev@xxxxxxxxxxx
> To change your delivery options, retrieve your password, or unsubscribe from this list, visit
> https://www.eclipse.org/mailman/listinfo/websocket-dev
>
_______________________________________________
websocket-dev mailing list
websocket-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://www.eclipse.org/mailman/listinfo/websocket-dev

Back to the top