Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [wakaama-dev] Welcome Achim Kraus as a new iot.wakaama Committer

Thanks, David,

I agree with your rules. 
I would purpose to handle "one PR per feature or Bugfix" in relation to the changes. Sometimes I got the impression (or experience), that adding a non trivial feature changes "some more files". To split them will either end in related parallel PRs or very long series of non parallel PRs requiring al lot of time (and patience). 

Best regards
Achim

Mit freundlichen Grüßen / Best regards

Achim Kraus

Bosch Software Innovations GmbH
Communications (INST/ESY4)
Stuttgarter Straße 130
71332 Waiblingen
GERMANY
www.bosch-si.de
www.blog.bosch-si.com 

Tel. +49 711 811-58139
achim.kraus@xxxxxxxxxxxx

Registered office: Berlin, Register court: Amtsgericht Charlottenburg, HRB 148411 B
Executives: Dr.-Ing. Rainer Kallenbach; Michael Hahn



-----Ursprüngliche Nachricht-----
Von: wakaama-dev-bounces@xxxxxxxxxxx [mailto:wakaama-dev-bounces@xxxxxxxxxxx] Im Auftrag von Navarro, David
Gesendet: Dienstag, 26. Mai 2015 10:43
An: Wakaama developer discussions
Betreff: Re: [wakaama-dev] Welcome Achim Kraus as a new iot.wakaama Committer

Welcome Achim,

Now there are more committers, I'd like to propose some basics "rules" on how to handle commits to wakaama.
- Direct commits to the master branch should be limited to compilation breakage fixes and edits to the documentation (ie. the README file)
- All other changes to master should be done through Pull Requests.
- No limitations on branches in wakaama as long as they are explicitly named.
- Opened PR on the core should be kept open long enough to gather comments (eg. 3-4 business days). No comments means no objection.
- Opened PR on the tests applications can be merged more quickly (1-2 business days).
- Bug fix PR can be merged almost immediately (after testing).

And for submitters:
- There should be one PR per new feature or bug fix.

Your thoughts ?

Regards,
David Navarro

-----Original Message-----
From: wakaama-dev-bounces@xxxxxxxxxxx [mailto:wakaama-dev-bounces@xxxxxxxxxxx] On Behalf Of portal on behalf of Julien Vermillard
Sent: Monday, 25 May, 2015 16:45
To: wakaama-dev@xxxxxxxxxxx
Subject: [wakaama-dev] Welcome Achim Kraus as a new iot.wakaama Committer

iot.wakaama Committers,
This automatically generated message marks the completion of all the legal paperwork and webmaster provisioning for Achim Kraus. Achim Kraus is a new full Committer on the iot.wakaama project.

Welcome!
_______________________________________________
wakaama-dev mailing list
wakaama-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit https://dev.eclipse.org/mailman/listinfo/wakaama-dev
---------------------------------------------------------------------
Intel Corporation SAS (French simplified joint stock company) Registered headquarters: "Les Montalets"- 2, rue de Paris,
92196 Meudon Cedex, France
Registration Number:  302 456 199 R.C.S. NANTERRE
Capital: 4,572,000 Euros

This e-mail and any attachments may contain confidential material for the sole use of the intended recipient(s). Any review or distribution by others is strictly prohibited. If you are not the intended recipient, please contact the sender and delete all copies.

_______________________________________________
wakaama-dev mailing list
wakaama-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit https://dev.eclipse.org/mailman/listinfo/wakaama-dev


Back to the top